Differential D4773

Catch invalid dates before marking a deposit as verified.
ClosedPublic
Actions

Authored by vlorentz on Dec 21 2020, 3:16 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T2906: Error on date parsing on the deposit

Commits

rDDEP24ec1889a4d0: Catch invalid dates before marking a deposit as verified.

Summary

Otherwise, querying /1/private/<deposit_id>/meta/ will crash because it fails
to parse the date.

Resolves T2906.

Diff Detail

Repository

rDDEP Push deposit

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 18051
Build 27877: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 27876: arc lint + arc unit

Event Timeline

vlorentz created this revision.Dec 21 2020, 3:16 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 21 2020, 3:16 PM

Build is green

Patch application report for D4773 (id=16896)

Rebasing onto 90507a44a1...

Current branch diff-target is up to date.

Changes applied before test

commit 24ec1889a4d002ed03b96d2613486e8ae17ca379
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Dec 21 15:16:11 2020 +0100

    Catch invalid dates before marking a deposit as verified.
    
    Otherwise, querying /1/private/<deposit_id>/meta/ will crash because it fails
    to parse the date.
    
    Resolves T2906.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/492/ for more details.

Harbormaster completed remote builds in B18051: Diff 16896.Dec 21 2020, 3:19 PM

ardumont accepted this revision.Dec 21 2020, 3:33 PM

This revision is now accepted and ready to land.Dec 21 2020, 3:33 PM

Closed by commit rDDEP24ec1889a4d0: Catch invalid dates before marking a deposit as verified. (authored by vlorentz). · Explain WhyDec 21 2020, 4:15 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDDEP24ec1889a4d0: Catch invalid dates before marking a deposit as verified..

ardumont mentioned this in T2906: Error on date parsing on the deposit.Dec 22 2020, 12:22 PM