Page MenuHomeSoftware Heritage
Differential D4765

Make tests pass as soon as the setup.py is initialized.
ClosedPublic
Actions

Authored by vlorentz on Dec 18 2020, 10:52 AM.

Details

Reviewers
zack
Group Reviewers
Reviewers
Commits
rDAUTH5b698bd437be: import template from swh-py-template (init-py-repo)
rDTPL7b556b93b437: Make tests pass as soon as the setup.py is initialized.
Summary

See comments on D4756

Diff Detail

Repository
rDTPL Python module template
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Dec 18 2020, 10:52 AM
Herald added a reviewer: Reviewers. · View Herald TranscriptDec 18 2020, 10:52 AM
Harbormaster failed remote builds in B18015: Diff 16863!Dec 18 2020, 10:53 AM
vlorentz edited the summary of this revision. (Show Details)Dec 22 2020, 5:25 PM
zack accepted this revision.Dec 22 2020, 6:04 PM
zack added a subscriber: zack.
zack added inline comments.
requirements-swh.txt
2

As per IRC discussion, this need is explained in D4756#118789, which is fine.
Please add a reference to it in a comment before landing though, otherwise it won't be clear for who reads the code.

This revision is now accepted and ready to land.Dec 22 2020, 6:04 PM
vlorentz updated this revision to Diff 16952.Dec 23 2020, 2:09 PM

add comment

Harbormaster failed remote builds in B18091: Diff 16952!Dec 23 2020, 2:09 PM
This revision was landed with ongoing or failed builds.Dec 23 2020, 2:09 PM
Closed by commit rDTPL7b556b93b437: Make tests pass as soon as the setup.py is initialized. (authored by vlorentz). · Explain Why
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDTPL7b556b93b437: Make tests pass as soon as the setup.py is initialized..
ardumont added a commit: rDAUTH5b698bd437be: import template from swh-py-template (init-py-repo).Mar 3 2021, 5:44 PM

Revision Contents
Changeset List

PathSize
2 lines
swh/
foo/
2 lines
tests/
3 lines

Diff 16953

View Options

requirements-swh.txt

Loading...
View Options

swh/foo/cli.py

Loading...
View Options

swh/foo/tests/test_nothing.py

Loading...
About · Developer information · Legal