It has a major regression for timestamps:
https://github.com/msgpack/msgpack-python/issues/451
Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Commits
- rDJNL5f7e43378c94: Blacklist msgpack 1.0.1.
Diff Detail
Diff Detail
- Repository
- rDJNL Journal infrastructure
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
Patch application report for D4760 (id=16854)
Could not rebase; Attempt merge onto d8cd3f9bbe...
Updating d8cd3f9..5f7e433 Fast-forward requirements.txt | 2 +- swh/journal/pytest_plugin.py | 23 +++++++++++++++++++++-- swh/journal/serializers.py | 12 +----------- swh/journal/tests/test_client.py | 2 +- 4 files changed, 24 insertions(+), 15 deletions(-)
Changes applied before test
commit 5f7e43378c942d51a064f96af12a486dc971864a Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Thu Dec 17 15:08:34 2020 +0100 Blacklist msgpack 1.0.1. It has a major regression for timestamps: https://github.com/msgpack/msgpack-python/issues/451 commit c4bf313c83e9a832cde2dc11f3fce6e351eed43b Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Thu Dec 17 13:03:18 2020 +0100 serializers: Deserialize as lists instead of tuples 1. for consistency with the serializers in swh.core 2. it's not clear to me that we ever needed that (it was added in 64cd01fc7c049123e16341fa93239013f152bacc with no rational) 3. it messes with swh-search reading from the journal and expecting JSON-like data.
See https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/137/ for more details.