Differential D4755

Add Tushar Goel in contributors
ClosedPublic
Actions

Authored by TG1999 on Dec 17 2020, 10:30 AM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Commits

rDMFCD47e7b7f991fa: Add Tushar to contributors

Required Signatures

L3 Software Heritage Contributor License Agreement, version 1.0

Summary

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>

Diff Detail

Repository

rDMFCD ClearlyDefined metadata fetcher

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

TG1999 created this revision.Dec 17 2020, 10:30 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 17 2020, 10:30 AM

Herald added a required legal document: L3 Software Heritage Contributor License Agreement, version 1.0. · View Herald Transcript

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DMFCD/job/tests-on-diff/1/
See console output for more information: https://jenkins.softwareheritage.org/job/DMFCD/job/tests-on-diff/1/console

Harbormaster failed remote builds in B17989: Diff 16836!Dec 17 2020, 10:30 AM

add contributor name

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DMFCD/job/tests-on-diff/2/
See console output for more information: https://jenkins.softwareheritage.org/job/DMFCD/job/tests-on-diff/2/console

Harbormaster failed remote builds in B17990: Diff 16837!Dec 17 2020, 10:34 AM

Thanks! Could you squash your two commits? (currently there is one adding to AUTHORS, then an other one undoing that and adding to CONTRIBUTORS)?

Could you also amend the commit message to be a little bit more explicit (eg. "Add myself to CONTRIBUTORS" or "Add Tushar Goel to CONTRIBUTORS"). It doesn't matter much for such a small change, but it's a good habit to write explicit commit messages

Oh, and add an empty line at the end of the file, it's missing

Thanks! Could you squash your two commits? (currently there is one adding to AUTHORS, then an other one undoing that and adding to CONTRIBUTORS)?

Could you also amend the commit message to be a little bit more explicit (eg. "Add myself to CONTRIBUTORS" or "Add Tushar Goel to CONTRIBUTORS"). It doesn't matter much for such a small change, but it's a good habit to write explicit commit messages

Right.

We have a documentation page which could help you with hints ;)

https://wiki.softwareheritage.org/wiki/Git_style_guide

Add Tushar Goel in contributors

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DMFCD/job/tests-on-diff/4/
See console output for more information: https://jenkins.softwareheritage.org/job/DMFCD/job/tests-on-diff/4/console

Harbormaster failed remote builds in B18004: Diff 16851!Dec 17 2020, 1:53 PM

TG1999 retitled this revision from add author name to Add Tushar Goel in contributors.Dec 17 2020, 1:58 PM

vlorentz accepted this revision.Dec 17 2020, 1:58 PM

This revision is now accepted and ready to land.Dec 17 2020, 1:58 PM

This revision was landed with ongoing or failed builds.Dec 17 2020, 3:09 PM

Closed by commit rDMFCD47e7b7f991fa: Add Tushar to contributors (authored by TG1999). · Explain Why

This revision was automatically updated to reflect the committed changes.

TG1999 added a commit: rDMFCD47e7b7f991fa: Add Tushar to contributors.

TG1999 reopened this revision.Dec 18 2020, 10:39 AM

This revision is now accepted and ready to land.Dec 18 2020, 10:39 AM

TG1999 abandoned this revision.Dec 18 2020, 10:40 AM

TG1999 reclaimed this revision.Dec 18 2020, 10:44 AM

This revision is now accepted and ready to land.Dec 18 2020, 10:44 AM

TG1999 closed this revision.Dec 18 2020, 10:44 AM

Revision Contents
Changeset List

Path

Size

1 line

Diff 16855

CONTRIBUTORS

Loading...