Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Details
Details
- Reviewers
vlorentz - Group Reviewers
Reviewers - Commits
- rDMFCD47e7b7f991fa: Add Tushar to contributors
- Required Signatures
L3 Software Heritage Contributor License Agreement, version 1.0
Diff Detail
Diff Detail
- Repository
- rDMFCD ClearlyDefined metadata fetcher
- Branch
- authors
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 17990 Build 27786: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 27785: arc lint + arc unit
Event Timeline
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DMFCD/job/tests-on-diff/1/
See console output for more information: https://jenkins.softwareheritage.org/job/DMFCD/job/tests-on-diff/1/console
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DMFCD/job/tests-on-diff/2/
See console output for more information: https://jenkins.softwareheritage.org/job/DMFCD/job/tests-on-diff/2/console
Comment Actions
Thanks! Could you squash your two commits? (currently there is one adding to AUTHORS, then an other one undoing that and adding to CONTRIBUTORS)?
Could you also amend the commit message to be a little bit more explicit (eg. "Add myself to CONTRIBUTORS" or "Add Tushar Goel to CONTRIBUTORS"). It doesn't matter much for such a small change, but it's a good habit to write explicit commit messages
Comment Actions
Thanks! Could you squash your two commits? (currently there is one adding to AUTHORS, then an other one undoing that and adding to CONTRIBUTORS)?
Could you also amend the commit message to be a little bit more explicit (eg. "Add myself to CONTRIBUTORS" or "Add Tushar Goel to CONTRIBUTORS"). It doesn't matter much for such a small change, but it's a good habit to write explicit commit messages
Right.
We have a documentation page which could help you with hints ;)
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DMFCD/job/tests-on-diff/4/
See console output for more information: https://jenkins.softwareheritage.org/job/DMFCD/job/tests-on-diff/4/console