Fixes T2838.
Details
Details
- Reviewers
zack - Group Reviewers
Reviewers - Maniphest Tasks
- T2838: "swh fs mount" silently fails if fusermount3 isn't available
- Commits
- rDFUSE9546ba2f7bd5: cli: raise error when missing fusermount3 dependency
Diff Detail
Diff Detail
- Repository
- rDFUSE FUSE virtual file system
- Branch
- feature/check-fusermount3-binary
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 17976 Build 27768: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 27767: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D4752 (id=16820)
Rebasing onto 7154e451ff...
Current branch diff-target is up to date.
Changes applied before test
commit 9546ba2f7bd54b4710bfe41000337a76a0e087d2
Author: Thibault Allançon <haltode@gmail.com>
Date: Wed Dec 16 11:33:31 2020 +0100
cli: raise error when missing fusermount3 dependency
Fixes T2838.See https://jenkins.softwareheritage.org/job/DFUSE/job/tests-on-diff/239/ for more details.
Comment Actions
conditionally accepted, please generalize the check before landing (see comment)
| swh/fuse/cli.py | ||
|---|---|---|
| 62 | let's be a bit more robust here, and look for both fusermount3 and fusermount before failing | |
| swh/fuse/cli.py | ||
|---|---|---|
| 62 | As discussed on IRC, pyfuse3 needs libfuse>3.3.0. | |