Differential D4752

FUSE: cli: raise error when missing fusermount3 dependency
ClosedPublic
Actions

Authored by haltode on Dec 16 2020, 11:36 AM.

Details

Reviewers

zack

Group Reviewers

Reviewers

Maniphest Tasks

T2838: "swh fs mount" silently fails if fusermount3 isn't available

Commits

rDFUSE9546ba2f7bd5: cli: raise error when missing fusermount3 dependency

Summary

Fixes T2838.

Diff Detail

Repository

rDFUSE FUSE virtual file system

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

haltode created this revision.Dec 16 2020, 11:36 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 16 2020, 11:36 AM

Build is green

Patch application report for D4752 (id=16820)

Rebasing onto 7154e451ff...

Current branch diff-target is up to date.

Changes applied before test

commit 9546ba2f7bd54b4710bfe41000337a76a0e087d2
Author: Thibault Allançon <haltode@gmail.com>
Date:   Wed Dec 16 11:33:31 2020 +0100

    cli: raise error when missing fusermount3 dependency
    
    Fixes T2838.

See https://jenkins.softwareheritage.org/job/DFUSE/job/tests-on-diff/239/ for more details.

Harbormaster completed remote builds in B17976: Diff 16820.Dec 16 2020, 11:40 AM

conditionally accepted, please generalize the check before landing (see comment)

swh/fuse/cli.py
61	let's be a bit more robust here, and look for both fusermount3 and fusermount before failing

This revision is now accepted and ready to land.Dec 16 2020, 11:56 AM

haltode marked an inline comment as done.Dec 16 2020, 2:30 PM

haltode added inline comments.

swh/fuse/cli.py
61	As discussed on IRC, pyfuse3 needs libfuse>3.3.0.

Closed by commit rDFUSE9546ba2f7bd5: cli: raise error when missing fusermount3 dependency (authored by haltode). · Explain WhyDec 16 2020, 2:30 PM

This revision was automatically updated to reflect the committed changes.

haltode marked an inline comment as done.

haltode added a commit: rDFUSE9546ba2f7bd5: cli: raise error when missing fusermount3 dependency.

Revision Contents
Changeset List

Path

Size

swh/

fuse/

cli.py

5 lines

Diff 16825

View Options

FUSE: cli: raise error when missing fusermount3 dependencyClosedPublicActions