Page MenuHomeSoftware Heritage
Differential D4750

journalprocessor: fix hashing of origin_visit_status objects
ClosedPublic
Actions

Authored by seirl on Dec 15 2020, 10:03 PM.

Details

Reviewers
olasd
Group Reviewers
Reviewers
Commits
rDDATASETf3b156598000: journalprocessor: fix hashing of origin_visit_status objects
Test Plan

Unfortunately there aren't unit tests for this part yet

Diff Detail

Repository
rDDATASET Datasets
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17974
Build 27765: arc lint + arc unit

Event Timeline

seirl created this revision.Dec 15 2020, 10:03 PM
Harbormaster completed remote builds in B17974: Diff 16818.Dec 15 2020, 10:03 PM
seirl added a reviewer: Reviewers.Dec 15 2020, 10:03 PM
olasd accepted this revision.Dec 15 2020, 10:07 PM
olasd added a subscriber: olasd.

Tentatively accepted; not 100% sure about what the actual type of the date field is, you'll need to check that...

swh/dataset/journalprocessor.py
373

I think it's supposed to be a datetime object, so you'll probably want to use .timestamp() on it to "normalize" it?

This revision is now accepted and ready to land.Dec 15 2020, 10:07 PM
seirl updated this revision to Diff 16833.Dec 16 2020, 4:40 PM

Normalize .timestamp()

Harbormaster completed remote builds in B17987: Diff 16833.Dec 16 2020, 4:40 PM
Closed by commit rDDATASETf3b156598000: journalprocessor: fix hashing of origin_visit_status objects (authored by seirl). · Explain WhyDec 16 2020, 4:41 PM
This revision was automatically updated to reflect the committed changes.
seirl added a commit: rDDATASETf3b156598000: journalprocessor: fix hashing of origin_visit_status objects.

Revision Contents
Changeset List

PathSize
swh/
dataset/
12 lines

Diff 16818

View Options

swh/dataset/journalprocessor.py

Loading...
About · Developer information · Legal