Page MenuHomeSoftware Heritage

Trap and report exceptions in a unified way within the cli
ClosedPublic

Authored by ardumont on Dec 14 2020, 11:15 PM.

Diff Detail

Repository
rDDEP Push deposit
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D4738 (id=16779)

Could not rebase; Attempt merge onto 73ee587df9...

Updating 73ee587d..95d50ea0
Fast-forward
 swh/deposit/api/common.py                          |   3 +-
 swh/deposit/cli/client.py                          | 101 +++++++++++--
 swh/deposit/client.py                              |  31 ++++
 swh/deposit/parsers.py                             | 100 -------------
 swh/deposit/tests/api/test_parsers.py              | 115 +--------------
 swh/deposit/tests/cli/test_client.py               | 163 +++++++++++++++++++++
 .../1_servicedocument                              |  26 ++++
 .../data/https_deposit.test.metadataonly/1_test    |  12 ++
 swh/deposit/tests/test_utils.py                    | 111 ++++++++++++++
 swh/deposit/utils.py                               | 110 +++++++++++++-
 10 files changed, 537 insertions(+), 235 deletions(-)
 create mode 100644 swh/deposit/tests/data/https_deposit.test.metadataonly/1_servicedocument
 create mode 100644 swh/deposit/tests/data/https_deposit.test.metadataonly/1_test
Changes applied before test
commit 95d50ea0fff4d1004dbf0252de77dc9f251dfa9a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Dec 14 23:14:01 2020 +0100

    Trap and report exceptions in a unified way within the cli
    
    Related to T2886

commit a25f57c3a6411816890c54b42a940a5b56e38f27
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Dec 14 22:05:17 2020 +0100

    Allow metadata-only deposit client side
    
    Related to T2886

commit 36f0b632966bf94ff2d4b9880e1ca89c6b14a68e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Dec 14 17:43:36 2020 +0100

    Move parse_swh_reference to swh.deposit.utils namespace
    
    So it can be reused in other non django part of the deposit.
    
    Related to T2886

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/483/ for more details.

This revision is now accepted and ready to land.Dec 15 2020, 10:24 AM

Build is green

Patch application report for D4738 (id=16783)

Could not rebase; Attempt merge onto 73ee587df9...

Updating 73ee587d..1bc55903
Fast-forward
 swh/deposit/api/common.py             |   3 +-
 swh/deposit/cli/client.py             |  38 ++++++-----
 swh/deposit/parsers.py                | 100 -----------------------------
 swh/deposit/tests/api/test_parsers.py | 115 +---------------------------------
 swh/deposit/tests/test_utils.py       | 111 ++++++++++++++++++++++++++++++++
 swh/deposit/utils.py                  | 106 ++++++++++++++++++++++++++++++-
 6 files changed, 240 insertions(+), 233 deletions(-)
Changes applied before test
commit 1bc55903126e3e1f847cbb29e2e4fd20d84401c1
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Dec 14 23:14:01 2020 +0100

    Trap and report exceptions in a unified way within the cli
    
    Related to T2886

commit 36f0b632966bf94ff2d4b9880e1ca89c6b14a68e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Dec 14 17:43:36 2020 +0100

    Move parse_swh_reference to swh.deposit.utils namespace
    
    So it can be reused in other non django part of the deposit.
    
    Related to T2886

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/484/ for more details.