Differential D4724

Add test for long descriptions.
ClosedPublic
Actions

Authored by vlorentz on Dec 11 2020, 2:31 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDSEAb47bea254704: Add test for long descriptions.

Summary

Just to make sure they don't crash, which would happen if,
for example, ES tried to store them untokenized.

Diff Detail

Repository

rDSEA Archive search

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 17896
Build 27650: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 27649: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	414 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.search.tests.test_in_memory.InmemorySearchTest::test_origin_intrinsic_metadata_long_description self = <swh.search.tests.test_in_memory.InmemorySearchTest testMethod=test_origin_intrinsic_metadata_long_description> def test_origin_intrinsic_metadata_long_description(self):
	12,611 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.search.tests.test_api_client.TestRemoteSearch::test_origin_intrinsic_metadata_all_terms
	331 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.search.tests.test_api_client.TestRemoteSearch::test_origin_intrinsic_metadata_description
	460 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.search.tests.test_api_client.TestRemoteSearch::test_origin_intrinsic_metadata_inconsistent_type
	3,503 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.search.tests.test_api_client.TestRemoteSearch::test_origin_intrinsic_metadata_long_description
		View Full Test Results (1 Failed · 51 Passed · 7 Skipped)

Event Timeline

vlorentz created this revision.Dec 11 2020, 2:31 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 11 2020, 2:31 PM

Build has FAILED

Patch application report for D4724 (id=16731)

Rebasing onto 4d860febb5...

Current branch diff-target is up to date.

Changes applied before test

commit 08959975c1921b868aa616f4fc120127de98cd87
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Dec 11 14:31:36 2020 +0100

    Add test for long descriptions.
    
    Just to make sure they don't crash, which would happen if,
    for example, ES tried to store them untokenized.

Link to build: https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/60/
See console output for more information: https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/60/console

Harbormaster failed remote builds in B17896: Diff 16731!Dec 11 2020, 2:34 PM

skip test

Build is green

Patch application report for D4724 (id=16733)

Rebasing onto 4d860febb5...

Current branch diff-target is up to date.

Changes applied before test

commit b47bea25470415fc7e2c19acd67d8c90b9a3d70a
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Dec 11 14:31:36 2020 +0100

    Add test for long descriptions.
    
    Just to make sure they don't crash, which would happen if,
    for example, ES tried to store them untokenized.

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/61/ for more details.

Harbormaster completed remote builds in B17897: Diff 16733.Dec 11 2020, 2:39 PM

ardumont accepted this revision.Dec 11 2020, 2:45 PM

This revision is now accepted and ready to land.Dec 11 2020, 2:45 PM

Closed by commit rDSEAb47bea254704: Add test for long descriptions. (authored by vlorentz). · Explain WhyDec 11 2020, 2:54 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDSEAb47bea254704: Add test for long descriptions..