Differential D4685

server: Remove deprecated services default config
ClosedPublic
Actions

Authored by tenma on Dec 8 2020, 2:33 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDVAU1b6a10fded60: vault: Remove deprecated services default config

Summary

Services configuration are mandatory, so merging with default
config can only lead to discrepancies with service that may have
alternative configuration structure.

Related to D4677

Test Plan

tox

Diff Detail

Repository

rDVAU Software Heritage Vault

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

tenma created this revision.Dec 8 2020, 2:33 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 8 2020, 2:33 PM

Build is green

Patch application report for D4685 (id=16628)

Could not rebase; Attempt merge onto 4e1fb5e04c...

Updating 4e1fb5e..1b6a10f
Fast-forward
 swh/vault/api/server.py |  9 +--------
 swh/vault/cli.py        | 12 +-----------
 2 files changed, 2 insertions(+), 19 deletions(-)

Changes applied before test

commit 1b6a10fded608c472c445a6b4467f0d56ec002f5
Author: tenma <tenma+swh@mailbox.org>
Date:   Tue Dec 8 10:16:21 2020 +0100

    vault: Remove deprecated services default config
    
    Services configuration are mandatory, so merging with default
    config can only lead to discrepancies with service that may have
    alternative configuration structure.

commit 91f64b9e7a6feba388986fd8fe733d21baf01a3d
Author: tenma <tenma+swh@mailbox.org>
Date:   Wed Dec 2 10:29:13 2020 +0100

    cli: Remove deprecated logging configuration
    
    CLI logging is configured at SWH CLI root.

See https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/60/ for more details.

Harbormaster completed remote builds in B17804: Diff 16628.Dec 8 2020, 2:34 PM