Differential D4624

storage.writer: Fix journal writer sanitizer function
ClosedPublic
Actions

Authored by ardumont on Nov 27 2020, 2:29 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDCIDX28ae49da346d: storage.writer: Fix journal writer sanitizer function

Summary

According to the value_sanitizer docstring, this takes 2 parameters, first is
the object type, the second is the actual dict value to sanitize. As a somewhat
default identity function, this discards the object type and returns directly
the dict value unchanged.

[1] https://forge.softwareheritage.org/source/swh-journal/browse/master/swh/journal/writer/kafka.py$97-100

Test Plan

tox

vagrant is ok with patched indexer storage, running the actual swh-indexer-journal-client up to writing to the new swh.journal.indexed.* topics.

Diff Detail

Repository

rDCIDX Metadata indexer

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 17591
Build 27192: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 27191: arc lint + arc unit

Event Timeline

ardumont created this revision.Nov 27 2020, 2:29 PM

ardumont edited the test plan for this revision. (Show Details)Nov 27 2020, 2:31 PM

Build is green

Patch application report for D4624 (id=16399)

Rebasing onto 73e181b055...

Current branch diff-target is up to date.

Changes applied before test

commit 28ae49da346db3ad876d5071e31a99658254cc04
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Nov 27 14:26:30 2020 +0100

    storage.writer: Fix journal writer sanitizer function
    
    According to the value_sanitizer docstring, this takes 2 parameters, first is
    the object type, the second is the actual dict value to sanitize. As a somewhat
    default identity function, this discards the object type and returns directly
    the dict value unchanged.
    
    [1] https://forge.softwareheritage.org/source/swh-journal/browse/master/swh/journal/writer/kafka.py$97-100

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/130/ for more details.

Harbormaster completed remote builds in B17591: Diff 16399.Nov 27 2020, 2:31 PM

vlorentz accepted this revision.Nov 27 2020, 2:32 PM

This revision is now accepted and ready to land.Nov 27 2020, 2:32 PM

Closed by commit rDCIDX28ae49da346d: storage.writer: Fix journal writer sanitizer function (authored by ardumont). · Explain WhyNov 27 2020, 2:36 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDCIDX28ae49da346d: storage.writer: Fix journal writer sanitizer function.