Differential D4618

test_mimetype: Refactor test to use pytest.mark.parametrize
ClosedPublic
Actions

Authored by ardumont on Nov 27 2020, 10:37 AM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDCIDX8c95b872555e: test_mimetype: Refactor test to use pytest.mark.parametrize

Summary

It's simplifying reading and more consistent with other similar tests

Another diff is coming which changes this a bit.

Test Plan

tox

Diff Detail

Repository

rDCIDX Metadata indexer

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Nov 27 2020, 10:37 AM

Build is green

Patch application report for D4618 (id=16369)

Rebasing onto 3d2034d572...

Current branch diff-target is up to date.

Changes applied before test

commit 8c95b872555ed6dd8e611a06747afe7805b84546
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Nov 27 10:26:49 2020 +0100

    test_mimetype: Refactor test to use pytest.mark.parametrize
    
    It's simplifying reading and more consistent with other similar tests

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/126/ for more details.

Harbormaster completed remote builds in B17561: Diff 16369.Nov 27 2020, 10:39 AM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 27 2020, 10:42 AM

Closed by commit rDCIDX8c95b872555e: test_mimetype: Refactor test to use pytest.mark.parametrize (authored by ardumont). · Explain Why

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDCIDX8c95b872555e: test_mimetype: Refactor test to use pytest.mark.parametrize.