Page MenuHomeSoftware Heritage
Differential D4609

Return the origin url on 'GET State-IRI'.
ClosedPublic
Actions

Authored by vlorentz on Nov 26 2020, 4:19 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Maniphest Tasks
T2806: Add tag in the deposit protocol to allow client to specify an origin
Commits
rDDEP4359a90e3a68: Return the origin url on 'GET State-IRI'.

Diff Detail

Event Timeline

vlorentz created this revision.Nov 26 2020, 4:19 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptNov 26 2020, 4:19 PM
swh-public-ci added a comment.Nov 26 2020, 4:23 PM

Build has FAILED

Patch application report for D4609 (id=16352)

Could not rebase; Attempt merge onto ad6041d312...

Updating ad6041d3..2f5aae7e
Fast-forward
 docs/endpoints/collection.rst                      |  2 --
 docs/specs/spec-loading.rst                        |  3 +-
 docs/specs/swh.xsd                                 | 35 ++++++++++++-------
 swh/deposit/api/collection.py                      | 12 ++-----
 swh/deposit/api/common.py                          | 39 +++++++++-------------
 swh/deposit/api/state.py                           |  1 +
 swh/deposit/cli/client.py                          | 16 ++++-----
 swh/deposit/client.py                              | 19 +++++++----
 swh/deposit/errors.py                              | 15 ---------
 .../0021_deposit_origin_url_20201124_1438.py       | 28 ++++++++++++++++
 swh/deposit/models.py                              |  9 +++--
 swh/deposit/templates/deposit/status.xml           |  1 +
 swh/deposit/tests/api/test_collection_post_atom.py | 19 ++++++++---
 .../tests/api/test_collection_post_binary.py       | 18 +++++++---
 .../tests/api/test_collection_post_multipart.py    | 18 +++++++---
 .../api/test_deposit_private_read_metadata.py      | 13 +++-----
 swh/deposit/tests/api/test_deposit_status.py       |  2 ++
 swh/deposit/tests/cli/test_client.py               |  8 ++---
 swh/deposit/urls.py                                |  4 +--
 19 files changed, 152 insertions(+), 110 deletions(-)
 create mode 100644 swh/deposit/migrations/0021_deposit_origin_url_20201124_1438.py
Changes applied before test
commit 2f5aae7e9c68937e2d4baa3080e916da2b76dde5
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Nov 25 19:18:26 2020 +0100

    Return the origin url on 'GET State-IRI'.

commit cb09d873dbe8a8037f34b3322bf83209d85ca706
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Nov 25 19:32:12 2020 +0100

    Fix mypy error.
    
    The 'type: ignore' comment makes errors on my machine,
    but removing it errors on Jenkins.
    So I'm fixing it by removing the name clash.

commit f863ea93a22b3132749261d479f9d2a8117d52bd
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Nov 26 14:45:48 2020 +0100

    Don't generate slugs on the client side
    
    They are not mandatory anymore.

commit fa3a3591e6932e16c13890f45b1bd26296954e74
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Nov 25 17:49:13 2020 +0100

    Make the Slug header optional.
    
    To follow the SWORD specification.

commit 45b596f198df963edb2d6f5353763704b16fd05d
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Nov 25 15:50:47 2020 +0100

    Defer origin_url computation until the deposit completes.
    
    In a future commit, the origin_url computation will only be a fallback
    in case it's not provided in any of the Atom entries; so we have
    to compute this fallback after all Atom entries are given, ie. when
    the deposit completes.

commit 1a2da5e1805f7d65cdd6c22b6180ad6fb00d623a
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Nov 24 15:52:36 2020 +0100

    add column 'origin_url' on Deposit.
    
    For now, it's only computed based on the external_id, but clients
    will provide it in future versions.

commit 2e4a524a2480dbd3baa6f59390528fd694ea7390
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Nov 24 12:20:19 2020 +0100

    swh.xsd: Use the https://www.softwareheritage.org/schema/2018/deposit namespace

commit 88b102aec44185b97b06135d862821bb4c138acc
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Nov 24 12:11:31 2020 +0100

    swh.xsd: Improve readability
    
    This also moves the inner element definitions of <swh:reference> to
    root elements, so they can be reused by new definitions in the future.

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/447/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/447/console

Harbormaster failed remote builds in B17545: Diff 16352!Nov 26 2020, 4:23 PM
vlorentz updated this revision to Diff 16381.Nov 27 2020, 11:22 AM

rebase

swh-public-ci added a comment.Nov 27 2020, 11:36 AM

Build is green

Patch application report for D4609 (id=16381)

Could not rebase; Attempt merge onto ad6041d312...

Updating ad6041d3..4359a90e
Fast-forward
 docs/endpoints/collection.rst                      |  2 --
 docs/specs/spec-loading.rst                        |  3 +-
 docs/specs/swh.xsd                                 | 35 ++++++++++++-------
 swh/deposit/api/collection.py                      | 12 ++-----
 swh/deposit/api/common.py                          | 39 +++++++++-------------
 swh/deposit/api/state.py                           |  1 +
 swh/deposit/cli/client.py                          | 16 ++++-----
 swh/deposit/client.py                              | 19 +++++++----
 swh/deposit/errors.py                              | 15 ---------
 .../0021_deposit_origin_url_20201124_1438.py       | 28 ++++++++++++++++
 swh/deposit/models.py                              |  9 +++--
 swh/deposit/templates/deposit/status.xml           |  1 +
 swh/deposit/tests/api/test_collection_post_atom.py | 19 ++++++++---
 .../tests/api/test_collection_post_binary.py       | 18 +++++++---
 .../tests/api/test_collection_post_multipart.py    | 18 +++++++---
 .../api/test_deposit_private_read_metadata.py      | 13 +++-----
 swh/deposit/tests/api/test_deposit_status.py       |  2 ++
 swh/deposit/tests/cli/test_client.py               |  8 ++---
 tox.ini                                            |  2 +-
 19 files changed, 151 insertions(+), 109 deletions(-)
 create mode 100644 swh/deposit/migrations/0021_deposit_origin_url_20201124_1438.py
Changes applied before test
commit 4359a90e3a688aeb11a719e5e4c96cd2aa1ed32e
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Nov 25 19:18:26 2020 +0100

    Return the origin url on 'GET State-IRI'.

commit f02b7f71fba1aeb6c3fdc1c7eb4e9118e13de2a0
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Nov 27 11:11:12 2020 +0100

    fix mypy error in swh/deposit/urls.py
    
    If djangorestframework-stubs does not contain the stub for
    `format_suffix_patterns`, then mypy does not see any issue on passing it
    a `List[object]` as argument, so the `# type: ignore` is useless,
    so mypy complains about it.

commit 5989af38c9e6b3d5e32e20bd125aa149d6668e8a
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Nov 26 14:45:48 2020 +0100

    Don't generate slugs on the client side
    
    They are not mandatory anymore.

commit fc5a5ee0b1c67c90c3eaf5a924a6c46eb6fb0f7f
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Nov 25 17:49:13 2020 +0100

    Make the Slug header optional.
    
    To follow the SWORD specification.

commit e7316d6d8a527eb4a96eb2e9d46daa0045c6b851
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Nov 25 15:50:47 2020 +0100

    Defer origin_url computation until the deposit completes.
    
    In a future commit, the origin_url computation will only be a fallback
    in case it's not provided in any of the Atom entries; so we have
    to compute this fallback after all Atom entries are given, ie. when
    the deposit completes.

commit a21961284e3b88a3c21fc0b67cae793351331e7f
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Nov 24 15:52:36 2020 +0100

    add column 'origin_url' on Deposit.
    
    For now, it's only computed based on the external_id, but clients
    will provide it in future versions.

commit 2e4a524a2480dbd3baa6f59390528fd694ea7390
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Nov 24 12:20:19 2020 +0100

    swh.xsd: Use the https://www.softwareheritage.org/schema/2018/deposit namespace

commit 88b102aec44185b97b06135d862821bb4c138acc
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Nov 24 12:11:31 2020 +0100

    swh.xsd: Improve readability
    
    This also moves the inner element definitions of <swh:reference> to
    root elements, so they can be reused by new definitions in the future.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/458/ for more details.

Harbormaster completed remote builds in B17573: Diff 16381.Nov 27 2020, 11:37 AM
ardumont accepted this revision.Nov 27 2020, 1:23 PM
This revision is now accepted and ready to land.Nov 27 2020, 1:23 PM
Closed by commit rDDEP4359a90e3a68: Return the origin url on 'GET State-IRI'. (authored by vlorentz). · Explain WhyNov 27 2020, 1:52 PM
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDDEP4359a90e3a68: Return the origin url on 'GET State-IRI'..
vlorentz added a task: T2806: Add tag in the deposit protocol to allow client to specify an origin.Nov 27 2020, 4:08 PM

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
swh/
deposit/
api/
1 line100%
Loading...
templates/
deposit/
1 line--
tests/
api/
2 lines98%
Loading...

Diff 16381

View Options

swh/deposit/api/state.py

Loading...
View Options

swh/deposit/templates/deposit/status.xml

Loading...
View Options

swh/deposit/tests/api/test_deposit_status.py

Loading...
About · Developer information · Legal