Differential D4606

test_journal_client: Migrate to pytest
ClosedPublic
Actions

Authored by ardumont on Nov 26 2020, 3:45 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDCIDX3d2034d57278: test_journal_client: Migrate to pytest

Summary

Because we moved away from unittest for some time now...

Test Plan

tox

Diff Detail

Repository

rDCIDX Metadata indexer

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Nov 26 2020, 3:45 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 26 2020, 3:45 PM

Build is green

Patch application report for D4606 (id=16348)

Could not rebase; Attempt merge onto d92c241980...

Updating d92c241..3d2034d
Fast-forward
 swh/indexer/cli.py                       |   2 +-
 swh/indexer/journal_client.py            |   4 +-
 swh/indexer/tests/test_cli.py            |   2 +-
 swh/indexer/tests/test_journal_client.py | 261 ++++++++++++++-----------------
 4 files changed, 124 insertions(+), 145 deletions(-)

Changes applied before test

commit 3d2034d572782b254ab35a0713951a3d530c4881
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Nov 26 15:25:36 2020 +0100

    test_journal_client: Migrate to pytest

commit 7e03cc687c00b44cb7fbd76467566ad2de52eed1
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Nov 26 15:12:55 2020 +0100

    indexer.journal_client: Subscribe to OriginVisitStatus topic
    
    ... instead of OriginVisit.
    
    OriginVisit model object no longer hold status information so the current
    filtering happening on the journal client side could not work.
    
    Related to T2814
    Related to P882

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/125/ for more details.

Harbormaster completed remote builds in B17541: Diff 16348.Nov 26 2020, 3:47 PM

anlambert accepted this revision.Nov 26 2020, 6:02 PM

This revision is now accepted and ready to land.Nov 26 2020, 6:02 PM

Closed by commit rDCIDX3d2034d57278: test_journal_client: Migrate to pytest (authored by ardumont). · Explain WhyNov 26 2020, 6:13 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDCIDX3d2034d57278: test_journal_client: Migrate to pytest.