Page MenuHomeSoftware Heritage
Differential D4602

add column 'origin_url' on Deposit.
ClosedPublic
Actions

Authored by vlorentz on Nov 26 2020, 1:12 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Maniphest Tasks
T2806: Add tag in the deposit protocol to allow client to specify an origin
Commits
rDDEPa21961284e3b: add column 'origin_url' on Deposit.
Summary

For now, it's only computed based on the external_id, but clients
will provide it in future versions.

Diff Detail

Repository
rDDEP Push deposit
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Nov 26 2020, 1:12 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptNov 26 2020, 1:12 PM
swh-public-ci added a comment.Nov 26 2020, 1:18 PM

Build is green

Patch application report for D4602 (id=16340)

Could not rebase; Attempt merge onto ad6041d312...

Updating ad6041d3..1a2da5e1
Fast-forward
 docs/specs/swh.xsd                                 | 35 ++++++++++++++--------
 swh/deposit/api/collection.py                      |  5 +++-
 swh/deposit/api/common.py                          |  5 ++++
 .../0021_deposit_origin_url_20201124_1438.py       | 28 +++++++++++++++++
 swh/deposit/models.py                              |  9 +++---
 .../api/test_deposit_private_read_metadata.py      |  3 ++
 6 files changed, 67 insertions(+), 18 deletions(-)
 create mode 100644 swh/deposit/migrations/0021_deposit_origin_url_20201124_1438.py
Changes applied before test
commit 1a2da5e1805f7d65cdd6c22b6180ad6fb00d623a
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Nov 24 15:52:36 2020 +0100

    add column 'origin_url' on Deposit.
    
    For now, it's only computed based on the external_id, but clients
    will provide it in future versions.

commit 2e4a524a2480dbd3baa6f59390528fd694ea7390
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Nov 24 12:20:19 2020 +0100

    swh.xsd: Use the https://www.softwareheritage.org/schema/2018/deposit namespace

commit 88b102aec44185b97b06135d862821bb4c138acc
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Nov 24 12:11:31 2020 +0100

    swh.xsd: Improve readability
    
    This also moves the inner element definitions of <swh:reference> to
    root elements, so they can be reused by new definitions in the future.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/442/ for more details.

Harbormaster completed remote builds in B17533: Diff 16340.Nov 26 2020, 1:18 PM
ardumont requested changes to this revision.Nov 26 2020, 2:07 PM
ardumont added a subscriber: ardumont.

lgtm except for one typo in the migration, remark inline.

swh/deposit/migrations/0021_deposit_origin_url_20201124_1438.py
10

missing the () call here.

This revision now requires changes to proceed.Nov 26 2020, 2:07 PM
vlorentz updated this revision to Diff 16376.Nov 27 2020, 11:21 AM

fix typo

swh-public-ci added a comment.Nov 27 2020, 11:24 AM

Build is green

Patch application report for D4602 (id=16376)

Could not rebase; Attempt merge onto ad6041d312...

Updating ad6041d3..a2196128
Fast-forward
 docs/specs/swh.xsd                                 | 35 ++++++++++++++--------
 swh/deposit/api/collection.py                      |  5 +++-
 swh/deposit/api/common.py                          |  5 ++++
 .../0021_deposit_origin_url_20201124_1438.py       | 28 +++++++++++++++++
 swh/deposit/models.py                              |  9 +++---
 .../api/test_deposit_private_read_metadata.py      |  3 ++
 6 files changed, 67 insertions(+), 18 deletions(-)
 create mode 100644 swh/deposit/migrations/0021_deposit_origin_url_20201124_1438.py
Changes applied before test
commit a21961284e3b88a3c21fc0b67cae793351331e7f
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Nov 24 15:52:36 2020 +0100

    add column 'origin_url' on Deposit.
    
    For now, it's only computed based on the external_id, but clients
    will provide it in future versions.

commit 2e4a524a2480dbd3baa6f59390528fd694ea7390
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Nov 24 12:20:19 2020 +0100

    swh.xsd: Use the https://www.softwareheritage.org/schema/2018/deposit namespace

commit 88b102aec44185b97b06135d862821bb4c138acc
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Nov 24 12:11:31 2020 +0100

    swh.xsd: Improve readability
    
    This also moves the inner element definitions of <swh:reference> to
    root elements, so they can be reused by new definitions in the future.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/453/ for more details.

Harbormaster completed remote builds in B17568: Diff 16376.Nov 27 2020, 11:24 AM
ardumont accepted this revision.Nov 27 2020, 11:41 AM
This revision is now accepted and ready to land.Nov 27 2020, 11:41 AM
Closed by commit rDDEPa21961284e3b: add column 'origin_url' on Deposit. (authored by vlorentz). · Explain WhyNov 27 2020, 1:52 PM
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDDEPa21961284e3b: add column 'origin_url' on Deposit..
vlorentz added a task: T2806: Add tag in the deposit protocol to allow client to specify an origin.Nov 27 2020, 4:08 PM

Revision Contents
Changeset List

PathSize
swh/
deposit/
api/
5 lines
5 lines
migrations/
28 lines
9 lines
tests/
api/
3 lines

Diff 16392

View Options

swh/deposit/api/collection.py

Loading...
View Options

swh/deposit/api/common.py

Loading...
View Options

swh/deposit/migrations/0021_deposit_origin_url_20201124_1438.py

Loading...
View Options

swh/deposit/models.py

Loading...
View Options

swh/deposit/tests/api/test_deposit_private_read_metadata.py

Loading...
About · Developer information · Legal