Page MenuHomeSoftware Heritage

Stop using the deprecated configuration scheme
ClosedPublic

Authored by ardumont on Nov 25 2020, 3:42 PM.

Details

Reviewers
anlambert
Group Reviewers
Reviewers
Summary

because it's confusing

This also fixes a logging statement to avoid the expansion and let the logging framework do its job.

Test Plan

tox still happy

Diff Detail

Repository
rDSCH Scheduling utilities
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17497
Build 27046: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 27045: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D4593 (id=16306)

Could not rebase; Attempt merge onto 9e5b17faa8...

Updating 9e5b17f..466273d
Fast-forward
 swh/scheduler/cli/__init__.py  | 6 +++---
 swh/scheduler/cli/task_type.py | 9 ++++-----
 2 files changed, 7 insertions(+), 8 deletions(-)
Changes applied before test
commit 466273d7244a7c2e85ae0a560c1eb7df8ae86095
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Nov 25 15:33:29 2020 +0100

    Stop using the deprecated configuration scheme

commit c50763348cb09636c70d22a12393157f4ee7f8d6
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Nov 25 15:30:10 2020 +0100

    cli.task_type: All task_type clis without a scheduler should raise
    
    As the code will plainly fail on calling methods on None instance if not caught
    early.

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/79/ for more details.

This revision is now accepted and ready to land.Nov 26 2020, 11:12 AM

Closed by 1b390a7b01f1bd022b7b21f8384e4b9289ec0b0a