Updating 566de211..8e86d68d
Fast-forward
 package.json                             |  1 -
 swh/web/assets/src/bundles/save/index.js | 65 ++++++++++++++++++--------------
 swh/web/assets/src/utils/functions.js    | 15 +++++---
 yarn.lock                                |  5 ---
 4 files changed, 46 insertions(+), 40 deletions(-)

Changes applied before test

commit 8e86d68d4ff925302598ee94ed40e151b4d017d7
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Nov 24 14:35:43 2020 +0100

    Make isGitRepoUrl saner by using a proper URL parser.

commit f3c180a59df0246c2f9b52309257399b06f7ea53
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Nov 24 14:28:05 2020 +0100

    Make validateSaveOriginUrl saner by using a proper URL parser.
    
    Also removes dependency on validate.js.

commit efcd3ad29c73265741e7398c5fe025777a954ed5
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Nov 24 13:36:26 2020 +0100

    isGitRepoUrl: disallow hashes in the URL
    
    It does not make sense to allow this for a git origin.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/497/ for more details.

Harbormaster completed remote builds in B17458: Diff 16264.Nov 24 2020, 2:57 PM

vlorentz added inline comments.Nov 24 2020, 3:00 PM

swh/web/assets/src/utils/functions.js
40–49	woah

default arg

Build is green

Patch application report for D4579 (id=16266)

Could not rebase; Attempt merge onto 566de21143...

Updating 566de211..5351c2f8
Fast-forward
 package.json                             |  1 -
 swh/web/assets/src/bundles/save/index.js | 65 ++++++++++++++++++--------------
 swh/web/assets/src/utils/functions.js    | 15 +++++---
 yarn.lock                                |  5 ---
 4 files changed, 46 insertions(+), 40 deletions(-)

Changes applied before test

commit 5351c2f85e320a7ca2bdb54aea0ae70d1db7b3df
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Nov 24 14:35:43 2020 +0100

    Make isGitRepoUrl saner by using a proper URL parser.

commit f3c180a59df0246c2f9b52309257399b06f7ea53
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Nov 24 14:28:05 2020 +0100

    Make validateSaveOriginUrl saner by using a proper URL parser.
    
    Also removes dependency on validate.js.

commit efcd3ad29c73265741e7398c5fe025777a954ed5
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Nov 24 13:36:26 2020 +0100

    isGitRepoUrl: disallow hashes in the URL
    
    It does not make sense to allow this for a git origin.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/498/ for more details.

Harbormaster completed remote builds in B17460: Diff 16266.Nov 24 2020, 3:09 PM

Closed by commit rDWAPPS5351c2f85e32: Make isGitRepoUrl saner by using a proper URL parser. (authored by vlorentz). · Explain WhyNov 24 2020, 3:29 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDWAPPS5351c2f85e32: Make isGitRepoUrl saner by using a proper URL parser..