Page MenuHomeSoftware Heritage

Make validateSaveOriginUrl saner by using a proper URL parser.
ClosedPublic

Authored by vlorentz on Nov 24 2020, 2:36 PM.

Details

Summary

Also removes dependency on validate.js.

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert added a subscriber: anlambert.

Thanks for cleaning my dirty code ;-)

This revision is now accepted and ready to land.Nov 24 2020, 2:50 PM

Build is green

Patch application report for D4578 (id=16263)

Could not rebase; Attempt merge onto 566de21143...

Updating 566de211..f3c180a5
Fast-forward
 package.json                             |  1 -
 swh/web/assets/src/bundles/save/index.js | 65 ++++++++++++++++++--------------
 swh/web/assets/src/utils/functions.js    |  2 +-
 yarn.lock                                |  5 ---
 4 files changed, 37 insertions(+), 36 deletions(-)
Changes applied before test
commit f3c180a59df0246c2f9b52309257399b06f7ea53
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Nov 24 14:28:05 2020 +0100

    Make validateSaveOriginUrl saner by using a proper URL parser.
    
    Also removes dependency on validate.js.

commit efcd3ad29c73265741e7398c5fe025777a954ed5
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Nov 24 13:36:26 2020 +0100

    isGitRepoUrl: disallow hashes in the URL
    
    It does not make sense to allow this for a git origin.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/496/ for more details.