Differential D4577

isGitRepoUrl: disallow hashes in the URL
ClosedPublic
Actions

Authored by vlorentz on Nov 24 2020, 2:36 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDWAPPSefcd3ad29c73: isGitRepoUrl: disallow hashes in the URL

Summary

It does not make sense to allow this for a git origin.

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Nov 24 2020, 2:36 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 24 2020, 2:36 PM

Build is green

Patch application report for D4577 (id=16262)

Rebasing onto 566de21143...

Current branch diff-target is up to date.

Changes applied before test

commit efcd3ad29c73265741e7398c5fe025777a954ed5
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Nov 24 13:36:26 2020 +0100

    isGitRepoUrl: disallow hashes in the URL
    
    It does not make sense to allow this for a git origin.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/495/ for more details.

Harbormaster completed remote builds in B17456: Diff 16262.Nov 24 2020, 2:43 PM