Differential D4573

_deposit_put: Don't create parent relationships between deposits of different users
ClosedPublic
Actions

Authored by vlorentz on Nov 24 2020, 1:20 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDDEPf612cdc00e71: _deposit_put: Don't create parent relationships between deposits of different…

Summary

Even if they share the same external-id, as external-ids are provider-specific.

The fix: 1 line
The diff with tests: 3 files changed, 146 insertions(+), 16 deletions(-)

Diff Detail

Repository

rDDEP Push deposit

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Nov 24 2020, 1:20 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 24 2020, 1:20 PM

Build is green

Patch application report for D4573 (id=16252)

Rebasing onto 2d03e1e7a3...

Current branch diff-target is up to date.

Changes applied before test

commit f612cdc00e7138868a349a261d5ccc4ca3b99fd6
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Nov 24 13:18:43 2020 +0100

    _deposit_put: Don't create parent relationships between deposits of different users
    
    Even if they share the same external-id, as external-ids are provider-specific.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/429/ for more details.

Harbormaster completed remote builds in B17444: Diff 16252.Nov 24 2020, 1:22 PM