Differential D4556

swh.vault.tests.conftest: Drop dead code
ClosedPublic
Actions

Authored by ardumont on Nov 23 2020, 1:10 PM.

Details

Reviewers

douardda

Group Reviewers

Reviewers

Commits

rDVAU4e1fb5e04c5a: swh.vault.tests.conftest: Drop dead code

Summary

This is just noise now during analysis.

Test Plan

tox

Diff Detail

Repository

rDVAU Software Heritage Vault

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Nov 23 2020, 1:10 PM

Build is green

Patch application report for D4556 (id=16184)

Could not rebase; Attempt merge onto 516e5956c9...

Updating 516e595..4e1fb5e
Fast-forward
 requirements-test.txt       | 1 -
 swh/vault/tests/conftest.py | 9 ---------
 2 files changed, 10 deletions(-)

Changes applied before test

commit 4e1fb5e04c5a2f55a849a7adbf4910ea7b39fdab
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Nov 23 13:05:35 2020 +0100

    swh.vault.tests.conftest: Drop dead code

commit 96fb83830a2c0e3f42a0c47c0e17c85e81ed752e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Nov 23 09:56:27 2020 +0100

    requirements-test.txt: Drop no longer needed test dependency
    
    It's already pulled from swh.core[db] which is a runtime dependency.
    
    Related to T2746

See https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/57/ for more details.

Harbormaster completed remote builds in B17384: Diff 16184.Nov 23 2020, 1:11 PM

ok, thanks, bye ;)

This revision was not accepted when it landed; it landed in state Needs Review.Nov 23 2020, 1:22 PM

Closed by commit rDVAU4e1fb5e04c5a: swh.vault.tests.conftest: Drop dead code (authored by ardumont). · Explain Why

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDVAU4e1fb5e04c5a: swh.vault.tests.conftest: Drop dead code.