Differential D4524

Remove <sword:request>.
ClosedPublic
Actions

Authored by vlorentz on Nov 19 2020, 1:57 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDDEP405b577f42ef: Remove <sword:request>.

Summary

Motivation:

it is not a SWORD tag
I don't think there is any use for this
Its content is buggy, as it only handles one level of hierarchy for the metadata values.

Diff Detail

Repository

rDDEP Push deposit

Branch

reorganize-sword

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 17240
Build 26616: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 26615: arc lint + arc unit

Event Timeline

vlorentz created this revision.Nov 19 2020, 1:57 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 19 2020, 1:57 PM

Build is green

Patch application report for D4524 (id=16034)

Rebasing onto 85416fb165...

Current branch diff-target is up to date.

Changes applied before test

commit 918d39057abe4a9194b0f7a0cc04e39bd297ec13
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Nov 19 13:56:39 2020 +0100

    Remove <sword:request>.
    
    Motivation:
    
    1. it is not a SWORD tag
    2. I don't think there is any use for this
    3. Its content is buggy, as it only handles one level of hierarchy for the metadata values.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/385/ for more details.

Harbormaster completed remote builds in B17240: Diff 16034.Nov 19 2020, 2:01 PM

i don't recall what this is... ¯\_(ツ)_/¯
Let's see if removing it make people scream i guess.

ardumont accepted this revision.Nov 19 2020, 3:58 PM

This revision is now accepted and ready to land.Nov 19 2020, 3:58 PM

rebase + update doc

Build is green

Patch application report for D4524 (id=16097)

Rebasing onto cb733dd49a...

Current branch diff-target is up to date.

Changes applied before test

commit 8ff2e68d8c32ebed6b11f062f643612e6a569725
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Nov 19 13:56:39 2020 +0100

    Remove <sword:request>.
    
    Motivation:
    
    1. it is not a SWORD tag
    2. I don't think there is any use for this
    3. Its content is buggy, as it only handles one level of hierarchy for the metadata values.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/399/ for more details.

Harbormaster completed remote builds in B17295: Diff 16097.Nov 20 2020, 11:08 AM

rebase

Build is green

Patch application report for D4524 (id=16126)

Rebasing onto f4b4c25e44...

Current branch diff-target is up to date.

Changes applied before test

commit 405b577f42efdb678aefa044b10599c7d2a1e97b
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Nov 19 13:56:39 2020 +0100

    Remove <sword:request>.
    
    Motivation:
    
    1. it is not a SWORD tag
    2. I don't think there is any use for this
    3. Its content is buggy, as it only handles one level of hierarchy for the metadata values.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/409/ for more details.

Harbormaster completed remote builds in B17326: Diff 16126.Nov 20 2020, 3:40 PM

Closed by commit rDDEP405b577f42ef: Remove <sword:request>. (authored by vlorentz). · Explain WhyNov 20 2020, 4:52 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDDEP405b577f42ef: Remove <sword:request>..