Page MenuHomeSoftware Heritage

Remove <sword:request>.
ClosedPublic

Authored by vlorentz on Nov 19 2020, 1:57 PM.

Details

Summary

Motivation:

  1. it is not a SWORD tag
  2. I don't think there is any use for this
  3. Its content is buggy, as it only handles one level of hierarchy for the metadata values.

Diff Detail

Repository
rDDEP Push deposit
Branch
reorganize-sword
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17240
Build 26616: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 26615: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D4524 (id=16034)

Rebasing onto 85416fb165...

Current branch diff-target is up to date.
Changes applied before test
commit 918d39057abe4a9194b0f7a0cc04e39bd297ec13
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Nov 19 13:56:39 2020 +0100

    Remove <sword:request>.
    
    Motivation:
    
    1. it is not a SWORD tag
    2. I don't think there is any use for this
    3. Its content is buggy, as it only handles one level of hierarchy for the metadata values.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/385/ for more details.

i don't recall what this is... ¯\_(ツ)_/¯
Let's see if removing it make people scream i guess.

This revision is now accepted and ready to land.Nov 19 2020, 3:58 PM

Build is green

Patch application report for D4524 (id=16097)

Rebasing onto cb733dd49a...

Current branch diff-target is up to date.
Changes applied before test
commit 8ff2e68d8c32ebed6b11f062f643612e6a569725
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Nov 19 13:56:39 2020 +0100

    Remove <sword:request>.
    
    Motivation:
    
    1. it is not a SWORD tag
    2. I don't think there is any use for this
    3. Its content is buggy, as it only handles one level of hierarchy for the metadata values.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/399/ for more details.

Build is green

Patch application report for D4524 (id=16126)

Rebasing onto f4b4c25e44...

Current branch diff-target is up to date.
Changes applied before test
commit 405b577f42efdb678aefa044b10599c7d2a1e97b
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Nov 19 13:56:39 2020 +0100

    Remove <sword:request>.
    
    Motivation:
    
    1. it is not a SWORD tag
    2. I don't think there is any use for this
    3. Its content is buggy, as it only handles one level of hierarchy for the metadata values.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/409/ for more details.

This revision was automatically updated to reflect the committed changes.