up -d is waiting the containers are "started" before returning the hand so you are sure the execs on line 169- can be executed.
You will also miss the return code of the docker-compose up command

WDYT to add a docker-compose logs -f & instead ?

you're right, that's much better

Harbormaster completed remote builds in B17220: Diff 16013.Nov 19 2020, 9:49 AM

ardumont accepted this revision.Nov 19 2020, 1:30 PM

This revision is now accepted and ready to land.Nov 19 2020, 1:30 PM

Closed by commit rDENVd69d98e868f9: Run 'docker-compose logs' while tests are running (authored by vlorentz). · Explain WhyNov 19 2020, 1:35 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDENVd69d98e868f9: Run 'docker-compose logs' while tests are running.

ardumont added a commit: rDENV35e31d329c8c: Revert "vault: Fix tests using the new key names".Nov 20 2020, 9:41 AM

Revision Contents
Changeset List

Path

Size

docker/

tests/

run_tests.sh

3 lines

Diff 16028

View Options

Run 'docker-compose up' in the background instead of detached, to show logs.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 16028

docker/tests/run_tests.sh

Run 'docker-compose up' in the background instead of detached, to show logs.
ClosedPublic
Actions

Revision Contents
Changeset List