Page MenuHomeSoftware Heritage

Run 'docker-compose up' in the background instead of detached, to show logs.

Authored by vlorentz on Thu, Nov 19, 9:25 AM.

Diff Detail

rDENV Development environment
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Thu, Nov 19, 9:25 AM

up -d is waiting the containers are "started" before returning the hand so you are sure the execs on line 169- can be executed.
You will also miss the return code of the docker-compose up command

WDYT to add a docker-compose logs -f & instead ?

vlorentz updated this revision to Diff 16013.Thu, Nov 19, 9:49 AM

you're right, that's much better

ardumont accepted this revision.Thu, Nov 19, 1:30 PM
This revision is now accepted and ready to land.Thu, Nov 19, 1:30 PM
This revision was automatically updated to reflect the committed changes.