Differential D440

sql/bin/db-init: simpler usage with sensible defaults
ClosedPublic
Actions

Authored by seirl on Sep 24 2018, 5:57 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Diff Detail

Repository

rDSTO Storage manager

Branch

easier-db-init

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 1442
Build 1786: arc lint + arc unit

Event Timeline

seirl created this revision.Sep 24 2018, 5:57 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 24 2018, 5:57 PM

fix usage docs to reflect default parameters

Thanks, I liked the idea. I've only reported minor things here and there.

sql/bin/db-init
20	what's the point of this cd? no command in the script invoke local commands anyway
28	this should be "DB_NAME [DB_USER [DB_PORT]]"
45	as we're going password-less, we shouldn't force a password for the new user with --pwprompt, it will be confusing

This revision now requires changes to proceed.Sep 25 2018, 9:41 AM

zack added inline comments.Sep 25 2018, 9:42 AM

sql/bin/db-init
20	oh, ignore this comment, I see in D441 why you want this

zack mentioned this in D441: getting-started: use DB peer auth.Sep 25 2018, 9:43 AM

seirl added inline comments.Sep 25 2018, 11:37 AM

sql/bin/db-init
45	If this script is only used for installing a dev environment, I can just remove this completely.

Fix POSIX usage arg documentation.

If you approve this, I'll just merge it and submit a second diff with all the useless parts removed.

zack accepted this revision.Sep 25 2018, 12:51 PM

This revision is now accepted and ready to land.Sep 25 2018, 12:51 PM

Harbormaster completed remote builds in B1435: Diff 1350.Sep 25 2018, 2:18 PM

Harbormaster completed remote builds in B1439: Diff 1354.

Harbormaster completed remote builds in B1442: Diff 1357.

Already merged.

Revision Contents
Changeset List

Path

Size

sql/

bin/

28 lines

Diff 1357

sql/bin/db-init

Loading...