Both requests.Request and _pytest.FixtureRequest objects are passed to
test fixtures as argument 'request'. This hurts readability.
Adding typing annotations makes it clear which one is meant.
Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Commits
- rDCORE12fa6f263d48: core tests: disambiguate arg 'request' through typing
Diff Detail
Diff Detail
- Repository
- rDCORE Foundations and core functionalities
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 16720 Build 25787: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 25786: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D4382 (id=15494)
Rebasing onto eefe1b6336...
Current branch diff-target is up to date.
Changes applied before test
commit 0005aebe550caf2d853912f6343970cf627bb3a8
Author: tenma <tenma+swh@mailbox.org>
Date: Thu Oct 29 14:43:52 2020 +0100
tests: disambiguate arg 'request' through typing
Both requests.Request and _pytest.FixtureRequest objects are passed to
test fixtures as argument 'request'. This hurts readability.
Adding typing annotations makes it clear which one is meant.See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/125/ for more details.
| swh/core/pytest_plugin.py | ||
|---|---|---|
| 13 | no need for the comment | |
Comment Actions
Build is green
Patch application report for D4382 (id=15503)
Rebasing onto 745448399e...
First, rewinding head to replay your work on top of it... Applying: core tests: disambiguate arg 'request' through typing
Changes applied before test
commit f66c70622ca0294d5d6413196b7f55406223cc8b
Author: tenma <tenma+swh@mailbox.org>
Date: Thu Oct 29 14:43:52 2020 +0100
core tests: disambiguate arg 'request' through typing
Both requests.Request and _pytest.FixtureRequest objects are passed to
test fixtures as argument 'request'. This hurts readability.
Adding typing annotations makes it clear which one is meant.See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/127/ for more details.
Comment Actions
Build is green
Patch application report for D4382 (id=15504)
Rebasing onto 745448399e...
Current branch diff-target is up to date.
Changes applied before test
commit 12fa6f263d48fdd200601057c0f724a60b771965
Author: tenma <tenma+swh@mailbox.org>
Date: Thu Oct 29 14:43:52 2020 +0100
core tests: disambiguate arg 'request' through typing
Both requests.Request and _pytest.FixtureRequest objects are passed to
test fixtures as argument 'request'. This hurts readability.
Adding typing annotations makes it clear which one is meant.See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/128/ for more details.