Page MenuHomeSoftware Heritage

Staging: refactor the postgresql declaration to configure the main cluster instance
ClosedPublic

Authored by vsellier on Oct 27 2020, 6:00 PM.

Diff Detail

Repository
rSPSITE puppet-swh-site
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision is now accepted and ready to land.Oct 27 2020, 6:18 PM
ardumont added inline comments.
site-modules/role/manifests/swh_database.pp
3

I was gonna say something about it but fine in the end.
That piece was redundant indeed.
In the swh_base role, it's already better defined [1]

We probably exchanged fast on it and forgot ¯\_(ツ)_/¯ ;)

[1] https://forge.softwareheritage.org/source/puppet-swh-site/browse/production/site-modules/role/manifests/swh_base.pp$13-15

data/deployments/staging/common.yaml
145 ↗(On Diff #15457)

@vsellier, we have to use the following for our incremental step experiment with db0 to work.

pgbouncer::auth_hba_file: "/etc/postgresql/%{alias('swh::postgresql::cluster_name')}"/pg_hba.conf"

(or override that value completely in db0.internal.staging.swh.network.yaml below)

db0:

$ grep pg_hba /etc/pgbouncer/pgbouncer.ini
auth_hba_file = /etc/postgresql/11/main/pg_hba.conf

-> cluster_name in there is 11/main not 12/main as we will start using for db1

data/deployments/staging/common.yaml
145 ↗(On Diff #15457)

well, lookup instead of alias...

  • refactor the postgresql declaration to configure the main cluster instance
vsellier added inline comments.
data/deployments/staging/common.yaml
145 ↗(On Diff #15457)

yes true, it's updated