mercurial.loader: Migrate to swh.model.hashutil.MultiHash
ClosedPublic
Actions

Authored by ardumont on Sep 21 2018, 6:06 PM.

Details

Reviewers

Commits

rDLDHG924c23452faf: mercurial.loader: Migrate to swh.model.hashutil.MultiHash
rDLDHGbdbf56e87d70: README.md: Remove unnecessary configuration (default)

Summary

Note that i potentially broke silently (due to no test T.T) when
migrating swh-model (~> removing the with_length from the
hashutil.hash_data function)

That also fixes it (and computes the length of the data one less
time).

Related D410

Test Plan

Manual

Following the readme samples [1] to execute the loading on repositories.

[1] https://forge.softwareheritage.org/D437#change-e9wbZ9Ppa6Oy

Diff Detail

Repository

rDLDHG Mercurial loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Sep 21 2018, 6:06 PM

Harbormaster completed remote builds in B1431: Diff 1345.Sep 21 2018, 6:06 PM

ardumont added inline comments.Sep 21 2018, 6:08 PM

README.md
32	No idea why i said that initially...
swh/loader/mercurial/bundle20_loader.py
230 ↗	(On Diff #1345)	Would have broken if we had had triggered new mercurial loading... (swh-model has been updated to the latest on swh-workers for running the loader-pypi).