Differential D431

bin: use pip-swh-packages instead of manually looking at the dependencies
ClosedPublic
Actions

Authored by seirl on Sep 19 2018, 6:10 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Commits

rDENVfecffc5055eb: bin: use pip-swh-packages instead of manually looking at the dependencies

Diff Detail

Repository

rDENV Development environment

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 1419
Build 1763: arc lint + arc unit

Event Timeline

seirl created this revision.Sep 19 2018, 6:10 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 19 2018, 6:10 PM

Harbormaster completed remote builds in B1417: Diff 1325.Sep 19 2018, 6:10 PM

zack requested changes to this revision.Sep 19 2018, 6:21 PM

zack added a subscriber: zack.

zack added inline comments.

bin/pip-install-deps
1	I don't think these two scripts should be removed. Just don't use it, but they might be useful in the future.
bin/pip-swh-packages
9	This is to filter out stuff like 'swh.storage[schemata]', but it's a bad workaround. Rather, bin/py-depgraph should remove the [...] part and keep the dependency: it will improve the rendering of the dependency graph and avoid the need of this workaround.

This revision now requires changes to proceed.Sep 19 2018, 6:21 PM

don't delete bin/pip-ls-deps

Harbormaster completed remote builds in B1418: Diff 1327.Sep 19 2018, 6:26 PM

bin: use pip-swh-packages instead of manually looking at the dependencies
move [] removal to py-depgraph

Harbormaster completed remote builds in B1419: Diff 1328.Sep 19 2018, 6:31 PM

rebase+fixup

Harbormaster completed remote builds in B1420: Diff 1329.Sep 19 2018, 6:32 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 19 2018, 6:41 PM

Closed by commit rDENVfecffc5055eb: bin: use pip-swh-packages instead of manually looking at the dependencies (authored by seirl). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

4 lines

bin/

pip-install-deps

pip-swh-packages

10 lines

5 lines

Diff 1328

.gitignore

Loading...

bin/pip-install-deps

Loading...

bin/pip-swh-packages

Loading...

bin/py-depgraph

Loading...