Differential D430

getting_started: install swh packages in a virtualenv
ClosedPublic
Actions

Authored by seirl on Sep 19 2018, 6:08 PM.

Details

Reviewers

zack

Commits

rDDOC5acfd929f2e9: getting_started: install swh packages in a virtualenv

Diff Detail

Repository

rDDOC Development documentation

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 1416
Build 1760: arc lint + arc unit

Event Timeline

seirl created this revision.Sep 19 2018, 6:08 PM

Harbormaster completed remote builds in B1416: Diff 1324.Sep 19 2018, 6:08 PM

looks good, thanks! only minor changes requested

docs/getting-started.rst
79	this should be something linke "install Python dependencies in a virtualenv"
99	the rest of the doc use "bin/" as prefix rather than "./bin/". It would be nice to adapt this line accordingly.

This revision now requires changes to proceed.Sep 19 2018, 6:26 PM

seirl added inline comments.Sep 19 2018, 6:35 PM

docs/getting-started.rst
79	Hmm... we do install SWH in a virtualenv here, not only the dependencies.

fix ./bin

Harbormaster completed remote builds in B1421: Diff 1330.Sep 19 2018, 6:36 PM

zack added inline comments.Sep 19 2018, 7:49 PM

docs/getting-started.rst
79	My point is that "install SWH" doesn't make sense. So maybe "install Python modules in a virtualenv" ?

This revision was not accepted when it landed; it landed in state Needs Review.Sep 20 2018, 10:12 AM

Closed by commit rDDOC5acfd929f2e9: getting_started: install swh packages in a virtualenv (authored by seirl, committed by zack). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

docs/

getting-started.rst

79 lines

Diff 1324

View Options

getting_started: install swh packages in a virtualenvClosedPublicActions