getting_started: install swh packages in a virtualenv
ClosedPublic
Actions

Authored by seirl on Sep 19 2018, 6:08 PM.

Details

Reviewers

zack

Commits

Repository

rDDOC Development documentation

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

looks good, thanks! only minor changes requested

docs/getting-started.rst
79–102	this should be something linke "install Python dependencies in a virtualenv"
98	the rest of the doc use "bin/" as prefix rather than "./bin/". It would be nice to adapt this line accordingly.

This revision now requires changes to proceed.Sep 19 2018, 6:26 PM

docs/getting-started.rst
79–102	Hmm... we do install SWH in a virtualenv here, not only the dependencies.

fix ./bin

docs/getting-started.rst
79–102	My point is that "install SWH" doesn't make sense. So maybe "install Python modules in a virtualenv" ?

This revision was not accepted when it landed; it landed in state Needs Review.Sep 20 2018, 10:12 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

docs/

79 lines