Differential D4288

storage.api.server: Add type to load_and_check_function and refactor tests
ClosedPublic
Actions

Authored by ardumont on Oct 16 2020, 3:09 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDSTO49d787c185a7: storage.api.server: Add type to load_and_check_config then refactor tests

Summary

That also allows me to check that the new config structure (no "args") is
already in place.

Test Plan

tox

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Oct 16 2020, 3:09 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 16 2020, 3:09 PM

Build has FAILED

Patch application report for D4288 (id=15158)

Rebasing onto 1a9687f0d4...

Current branch diff-target is up to date.

Changes applied before test

commit 93c283f1aa85f082ce0750def771d7ef51b7a3e3
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 16 15:03:38 2020 +0200

    storage.api.server: Add type to load_and_check_function and refactor tests

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1008/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1008/console

Harbormaster failed remote builds in B16386: Diff 15158!Oct 16 2020, 3:14 PM

Amend commit message
Fix test

Build is green

Patch application report for D4288 (id=15166)

Rebasing onto 1a9687f0d4...

Current branch diff-target is up to date.

Changes applied before test

commit 49d787c185a78d18748466bc74b8ae1879153eb7
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 16 15:03:38 2020 +0200

    storage.api.server: Add type to load_and_check_config then refactor tests
    
    This also drops the type parameter from load_and_check_config which is never
    used.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1009/ for more details.

Harbormaster completed remote builds in B16394: Diff 15166.Oct 16 2020, 4:03 PM

vlorentz accepted this revision.Oct 19 2020, 12:38 PM

vlorentz added a subscriber: vlorentz.

vlorentz added inline comments.