Page MenuHomeSoftware Heritage

storage.api.server: Add type to load_and_check_function and refactor tests
ClosedPublic

Authored by ardumont on Fri, Oct 16, 3:09 PM.

Details

Summary

That also allows me to check that the new config structure (no "args") is
already in place.

Test Plan

tox

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Fri, Oct 16, 3:09 PM

Build has FAILED

Patch application report for D4288 (id=15158)

Rebasing onto 1a9687f0d4...

Current branch diff-target is up to date.
Changes applied before test
commit 93c283f1aa85f082ce0750def771d7ef51b7a3e3
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 16 15:03:38 2020 +0200

    storage.api.server: Add type to load_and_check_function and refactor tests

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1008/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1008/console

ardumont updated this revision to Diff 15166.Fri, Oct 16, 3:58 PM
  • Amend commit message
  • Fix test

Build is green

Patch application report for D4288 (id=15166)

Rebasing onto 1a9687f0d4...

Current branch diff-target is up to date.
Changes applied before test
commit 49d787c185a78d18748466bc74b8ae1879153eb7
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 16 15:03:38 2020 +0200

    storage.api.server: Add type to load_and_check_config then refactor tests
    
    This also drops the type parameter from load_and_check_config which is never
    used.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1009/ for more details.

vlorentz accepted this revision.Mon, Oct 19, 12:38 PM
vlorentz added a subscriber: vlorentz.
vlorentz added inline comments.
swh/storage/api/server.py
104

drop the %

This revision is now accepted and ready to land.Mon, Oct 19, 12:38 PM
ardumont added inline comments.Mon, Oct 19, 3:08 PM
swh/storage/api/server.py
104
124

coverage should be better in D4306 now.