Page MenuHomeSoftware Heritage
Differential D4283

spec-technical: Add 'partial' self-loop + annotate transitions in the status diagram
ClosedPublic
Actions

Authored by vlorentz on Oct 16 2020, 11:01 AM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDDEP7cc8d3299e37: spec-technical: Add 'partial' self-loop + annotate transitions in the status…
Summary

status.svg9 KBDownload

Depends on D4281

Diff Detail

Repository
rDDEP Push deposit
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Oct 16 2020, 11:01 AM
Herald added a reviewer: Reviewers. · View Herald TranscriptOct 16 2020, 11:01 AM
vlorentz edited the summary of this revision. (Show Details)Oct 16 2020, 11:01 AM
swh-public-ci added a comment.Oct 16 2020, 11:04 AM

Build is green

Patch application report for D4283 (id=15141)

Could not rebase; Attempt merge onto 7e05dbe497...

Updating 7e05dbe4..7cc8d329
Fast-forward
 docs/images/status.png        | Bin 9825 -> 0 bytes
 docs/images/status.uml        |  27 +++++++++++++++++++++++++++
 docs/specs/spec-technical.rst |   6 +-----
 3 files changed, 28 insertions(+), 5 deletions(-)
 delete mode 100644 docs/images/status.png
 create mode 100644 docs/images/status.uml
Changes applied before test
commit 7cc8d3299e37c0c9fc916b31ab96931b48f7a6bc
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Oct 16 11:00:49 2020 +0200

    spec-technical: Add 'partial' self-loop + annotate transitions in the status diagram

commit efda75628fb1ac9330779259ecd244717596c0a9
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Oct 16 10:38:49 2020 +0200

    spec-technical: Rewrite state diagram using Plantuml.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/266/ for more details.

Harbormaster completed remote builds in B16369: Diff 15141.Oct 16 2020, 11:04 AM
ardumont requested changes to this revision.Oct 16 2020, 1:17 PM
ardumont added a subscriber: ardumont.

Nice.

docs/images/status.uml
7

It's:

without In-Progress or 
with In-Progress: False
10

Unsure we want to enter into that much details.
We can modify the deposit with more than this IRI (iirc).

This revision now requires changes to proceed.Oct 16 2020, 1:17 PM
vlorentz added inline comments.Oct 16 2020, 1:19 PM
docs/images/status.uml
7

isn't it equivalent to what I wrote (except longer)?

10

then we'll add other transitions

ardumont added inline comments.Oct 16 2020, 1:26 PM
docs/images/status.uml
7

mmm, yeah ok, it's equivalent. Although not immediately clear to me ¯\_(ツ)_/¯.

10

as you want, here you go:

ardumont added inline comments.Oct 16 2020, 1:38 PM
docs/images/status.uml
10

It's not per say other transitions, it's just the same arrow with different actions which takes place underneath.
The transition stays the same nonetheless.

ardumont accepted this revision.Oct 16 2020, 1:43 PM

Thanks.

You can add the other endpoints in another diff if you want ;)

Cheers,

This revision is now accepted and ready to land.Oct 16 2020, 1:43 PM
Closed by commit rDDEP7cc8d3299e37: spec-technical: Add 'partial' self-loop + annotate transitions in the status… (authored by vlorentz). · Explain WhyOct 16 2020, 6:21 PM
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDDEP7cc8d3299e37: spec-technical: Add 'partial' self-loop + annotate transitions in the status….

Revision Contents
Changeset List

PathSize
docs/
images/
20 lines

Diff 15173

View Options

docs/images/status.uml

Loading...
About · Developer information · Legal