Page MenuHomeSoftware Heritage
Differential D4277

django: Improve error handling
ClosedPublic
Actions

Authored by anlambert on Oct 15 2020, 7:36 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Maniphest Tasks
T2657: Improve HTTP errors reporting in tests
Commits
rDWAPPS3add0d1ee7ca: django: Improve error handling
Summary

Use a dedicated django middleware to handle uncaught exception raised when
processing a view and generate error response.

Related to T2657

Depends on D4276

Diff Detail

Repository
rDWAPPS Web applications
Branch
django-error-management-rework
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16356
Build 25187: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 25186: arc lint + arc unit

Event Timeline

anlambert created this revision.Oct 15 2020, 7:36 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptOct 15 2020, 7:36 PM
anlambert added a child revision: D4278: tests: Improve HTTP errors reporting.Oct 15 2020, 7:40 PM
anlambert updated this revision to Diff 15125.Oct 15 2020, 7:44 PM

Update commit message

anlambert retitled this revision from browse: Improve error handling to django: Improve error handling.Oct 15 2020, 7:44 PM
swh-public-ci added a comment.Oct 15 2020, 7:50 PM

Build is green

Patch application report for D4277 (id=15123)

Could not rebase; Attempt merge onto d948e60ecd...

Updating d948e60e..706829d8
Fast-forward
 swh/web/api/apidoc.py                    |  24 +--
 swh/web/api/apiresponse.py               |  61 ++++---
 swh/web/api/apiurls.py                   |  44 +++--
 swh/web/api/views/content.py             |   2 +-
 swh/web/api/views/origin_save.py         |   2 +-
 swh/web/api/views/revision.py            |   2 +-
 swh/web/api/views/vault.py               |  10 +-
 swh/web/auth/views.py                    | 114 +++++-------
 swh/web/browse/browseurls.py             |   1 +
 swh/web/browse/identifiers.py            |   6 +-
 swh/web/browse/snapshot_context.py       | 303 ++++++++++++++-----------------
 swh/web/browse/views/content.py          |  98 +++++-----
 swh/web/browse/views/directory.py        |  77 ++++----
 swh/web/browse/views/origin.py           |  16 +-
 swh/web/browse/views/release.py          |  73 ++++----
 swh/web/browse/views/revision.py         | 225 +++++++++++------------
 swh/web/common/exc.py                    |  11 +-
 swh/web/common/middlewares.py            |  18 ++
 swh/web/settings/common.py               |   2 +
 swh/web/tests/api/test_apiresponse.py    |  40 ++--
 swh/web/tests/api/views/__init__.py      |   2 +-
 swh/web/tests/common/test_middlewares.py |  41 +++++
 22 files changed, 587 insertions(+), 585 deletions(-)
 create mode 100644 swh/web/tests/common/test_middlewares.py
Changes applied before test
commit 706829d86bfcaf2f7f6dfaf33a2bc071d928fa7e
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Oct 7 18:04:04 2020 +0200

    browse: Improve error handling
    
    Use a dedicated django middleware to handle uncaught exception raised when
    processing a view and generate error response.
    
    Related to T2657

commit 65339606f4a1868665d0355beac7b5d6d0fa84ea
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Oct 7 16:44:55 2020 +0200

    api: Improve error handling and response management
    
    Use a custom DRF exception handler to generate an error response when an
    exception is raised in a view.
    
    Move api response creation from the api_doc decorator to the api_route one.
    
    Remove the handle_response parameter from the api_doc decorator.
    
    Related to T2657

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/415/ for more details.

Harbormaster completed remote builds in B16350: Diff 15123.Oct 15 2020, 7:50 PM
vlorentz accepted this revision.Oct 15 2020, 8:01 PM
vlorentz added a subscriber: vlorentz.

lots of red lines :)

This revision is now accepted and ready to land.Oct 15 2020, 8:01 PM
swh-public-ci added a comment.Oct 15 2020, 8:05 PM

Build is green

Patch application report for D4277 (id=15125)

Could not rebase; Attempt merge onto d948e60ecd...

Updating d948e60e..1c043710
Fast-forward
 swh/web/api/apidoc.py                    |  24 +--
 swh/web/api/apiresponse.py               |  61 ++++---
 swh/web/api/apiurls.py                   |  44 +++--
 swh/web/api/views/content.py             |   2 +-
 swh/web/api/views/origin_save.py         |   2 +-
 swh/web/api/views/revision.py            |   2 +-
 swh/web/api/views/vault.py               |  10 +-
 swh/web/auth/views.py                    | 114 +++++-------
 swh/web/browse/browseurls.py             |   1 +
 swh/web/browse/identifiers.py            |   6 +-
 swh/web/browse/snapshot_context.py       | 303 ++++++++++++++-----------------
 swh/web/browse/views/content.py          |  98 +++++-----
 swh/web/browse/views/directory.py        |  77 ++++----
 swh/web/browse/views/origin.py           |  16 +-
 swh/web/browse/views/release.py          |  73 ++++----
 swh/web/browse/views/revision.py         | 225 +++++++++++------------
 swh/web/common/exc.py                    |  11 +-
 swh/web/common/middlewares.py            |  18 ++
 swh/web/settings/common.py               |   2 +
 swh/web/tests/api/test_apiresponse.py    |  40 ++--
 swh/web/tests/api/views/__init__.py      |   2 +-
 swh/web/tests/common/test_middlewares.py |  41 +++++
 22 files changed, 587 insertions(+), 585 deletions(-)
 create mode 100644 swh/web/tests/common/test_middlewares.py
Changes applied before test
commit 1c043710cbde5df2cbabef8a00b49f25c432a567
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Oct 7 18:04:04 2020 +0200

    django: Improve error handling
    
    Use a dedicated django middleware to handle uncaught exception raised when
    processing a view and generate error response.
    
    Related to T2657

commit 65339606f4a1868665d0355beac7b5d6d0fa84ea
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Oct 7 16:44:55 2020 +0200

    api: Improve error handling and response management
    
    Use a custom DRF exception handler to generate an error response when an
    exception is raised in a view.
    
    Move api response creation from the api_doc decorator to the api_route one.
    
    Remove the handle_response parameter from the api_doc decorator.
    
    Related to T2657

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/417/ for more details.

Harbormaster completed remote builds in B16352: Diff 15125.Oct 15 2020, 8:05 PM
anlambert updated this revision to Diff 15129.Oct 15 2020, 9:58 PM

Rebase

swh-public-ci added a comment.Oct 15 2020, 10:11 PM

Build is green

Patch application report for D4277 (id=15129)

Could not rebase; Attempt merge onto d948e60ecd...

Updating d948e60e..11c2bbcc
Fast-forward
 swh/web/api/apidoc.py                    |  24 +--
 swh/web/api/apiresponse.py               |  61 ++++---
 swh/web/api/apiurls.py                   |  44 +++--
 swh/web/api/views/content.py             |   2 +-
 swh/web/api/views/origin_save.py         |   2 +-
 swh/web/api/views/revision.py            |   2 +-
 swh/web/api/views/vault.py               |  10 +-
 swh/web/auth/views.py                    | 114 +++++-------
 swh/web/browse/identifiers.py            |   6 +-
 swh/web/browse/snapshot_context.py       | 303 ++++++++++++++-----------------
 swh/web/browse/views/content.py          |  98 +++++-----
 swh/web/browse/views/directory.py        |  77 ++++----
 swh/web/browse/views/origin.py           |  16 +-
 swh/web/browse/views/release.py          |  73 ++++----
 swh/web/browse/views/revision.py         | 225 +++++++++++------------
 swh/web/common/exc.py                    |  11 +-
 swh/web/common/middlewares.py            |  18 ++
 swh/web/settings/common.py               |   2 +
 swh/web/tests/api/test_apiresponse.py    |  40 ++--
 swh/web/tests/api/views/__init__.py      |   2 +-
 swh/web/tests/common/test_middlewares.py |  41 +++++
 21 files changed, 586 insertions(+), 585 deletions(-)
 create mode 100644 swh/web/tests/common/test_middlewares.py
Changes applied before test
commit 11c2bbcc380b62dfe71630bece55f7c1bed76a40
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Oct 7 18:04:04 2020 +0200

    django: Improve error handling
    
    Use a dedicated django middleware to handle uncaught exception raised when
    processing a view and generate error response.
    
    Related to T2657

commit bd8b47d67345028ac843034cdcbe602e11e28c95
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Oct 7 16:44:55 2020 +0200

    api: Improve error handling and response management
    
    Use a custom DRF exception handler to generate an error response when an
    exception is raised in a view.
    
    Move api response creation from the api_doc decorator to the api_route one.
    
    Remove the handle_response parameter from the api_doc decorator.
    
    Related to T2657

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/420/ for more details.

Harbormaster completed remote builds in B16356: Diff 15129.Oct 15 2020, 10:11 PM
anlambert updated this revision to Diff 15249.Oct 20 2020, 12:41 PM

Rebase

swh-public-ci added a comment.Oct 20 2020, 12:54 PM

Build is green

Patch application report for D4277 (id=15249)

Could not rebase; Attempt merge onto 7fbb185005...

Updating 7fbb1850..3add0d1e
Fast-forward
 swh/web/api/apidoc.py                    |  24 +--
 swh/web/api/apiresponse.py               |  61 ++++---
 swh/web/api/apiurls.py                   |  44 +++--
 swh/web/api/views/content.py             |   2 +-
 swh/web/api/views/origin_save.py         |   2 +-
 swh/web/api/views/revision.py            |   2 +-
 swh/web/api/views/vault.py               |  10 +-
 swh/web/auth/views.py                    | 114 +++++-------
 swh/web/browse/identifiers.py            |   6 +-
 swh/web/browse/snapshot_context.py       | 303 ++++++++++++++-----------------
 swh/web/browse/views/content.py          |  98 +++++-----
 swh/web/browse/views/directory.py        |  77 ++++----
 swh/web/browse/views/origin.py           |  16 +-
 swh/web/browse/views/release.py          |  73 ++++----
 swh/web/browse/views/revision.py         | 225 +++++++++++------------
 swh/web/common/exc.py                    |  11 +-
 swh/web/common/middlewares.py            |  18 ++
 swh/web/settings/common.py               |   2 +
 swh/web/tests/api/test_apiresponse.py    |  40 ++--
 swh/web/tests/api/views/__init__.py      |   2 +-
 swh/web/tests/common/test_middlewares.py |  41 +++++
 21 files changed, 586 insertions(+), 585 deletions(-)
 create mode 100644 swh/web/tests/common/test_middlewares.py
Changes applied before test
commit 3add0d1ee7ca0b2b4b7c428ebfcdd5ba7a6be397
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Oct 7 18:04:04 2020 +0200

    django: Improve error handling
    
    Use a dedicated django middleware to handle uncaught exception raised when
    processing a view and generate error response.
    
    Related to T2657

commit 7c5e04cca483dda98c76d7482a7c345a03107676
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Oct 7 16:44:55 2020 +0200

    api: Improve error handling and response management
    
    Use a custom DRF exception handler to generate an error response when an
    exception is raised in a view.
    
    Move api response creation from the api_doc decorator to the api_route one.
    
    Remove the handle_response parameter from the api_doc decorator.
    
    Related to T2657

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/423/ for more details.

Harbormaster completed remote builds in B16481: Diff 15249.Oct 20 2020, 12:54 PM
Closed by commit rDWAPPS3add0d1ee7ca: django: Improve error handling (authored by anlambert). · Explain WhyOct 20 2020, 1:04 PM
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDWAPPS3add0d1ee7ca: django: Improve error handling.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
swh/
web/
auth/
114 lines99%
Loading...
browse/
6 lines100%
Loading...
303 lines80%
Loading...
views/
98 lines64%
Loading...
77 lines79%
Loading...
16 lines80%
Loading...
73 lines74%
Loading...
225 lines59%
Loading...
common/
11 lines80%
Loading...
18 lines60%
Loading...
settings/
1 line94%
Loading...
tests/
common/
41 lines100%
Loading...

Diff 15129

View Options

swh/web/auth/views.py

Loading...
View Options

swh/web/browse/identifiers.py

Loading...
View Options

swh/web/browse/snapshot_context.py

Loading...
View Options

swh/web/browse/views/content.py

Loading...
View Options

swh/web/browse/views/directory.py

Loading...
View Options

swh/web/browse/views/origin.py

Loading...
View Options

swh/web/browse/views/release.py

Loading...
View Options

swh/web/browse/views/revision.py

Loading...
View Options

swh/web/common/exc.py

Loading...
View Options

swh/web/common/middlewares.py

Loading...
View Options

swh/web/settings/common.py

Loading...
View Options

swh/web/tests/common/test_middlewares.py

Loading...
About · Developer information · Legal