Paths

Table of Contentst

Differential D4276

api: Improve error handling and response management
ClosedPublic
Actions

Authored by anlambert on Oct 15 2020, 7:36 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T2657: Improve HTTP errors reporting in tests

Commits

rDWAPPS7c5e04cca483: api: Improve error handling and response management

Summary

Use a custom DRF exception handler to generate an error response when an
exception is raised in a view.

Move api response creation from the api_doc decorator to the api_route one.

Remove the handle_response parameter from the api_doc decorator.

Related to T2657

Diff Detail

Repository

rDWAPPS Web applications

Branch

api-error-management-rework

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 16480
Build 25390: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 25389: arc lint + arc unit

Event Timeline

anlambert created this revision.Oct 15 2020, 7:36 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 15 2020, 7:36 PM

anlambert added a child revision: D4277: django: Improve error handling.Oct 15 2020, 7:36 PM

Build is green

Patch application report for D4276 (id=15122)

Rebasing onto d948e60ecd...

Current branch diff-target is up to date.

Changes applied before test

commit 65339606f4a1868665d0355beac7b5d6d0fa84ea
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Oct 7 16:44:55 2020 +0200

    api: Improve error handling and response management
    
    Use a custom DRF exception handler to generate an error response when an
    exception is raised in a view.
    
    Move api response creation from the api_doc decorator to the api_route one.
    
    Remove the handle_response parameter from the api_doc decorator.
    
    Related to T2657

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/414/ for more details.

Harbormaster completed remote builds in B16349: Diff 15122.Oct 15 2020, 7:43 PM

vlorentz accepted this revision.Oct 15 2020, 8:00 PM

vlorentz added a subscriber: vlorentz.

vlorentz added inline comments.

swh/web/api/apiresponse.py
213	equivalent to: `doc_data = getattr(exc, "doc_data", None)`

This revision is now accepted and ready to land.Oct 15 2020, 8:00 PM

Apply @vlorentz comment.

Build is green

Patch application report for D4276 (id=15128)

Rebasing onto d948e60ecd...

Current branch diff-target is up to date.

Changes applied before test

commit bd8b47d67345028ac843034cdcbe602e11e28c95
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Oct 7 16:44:55 2020 +0200

    api: Improve error handling and response management
    
    Use a custom DRF exception handler to generate an error response when an
    exception is raised in a view.
    
    Move api response creation from the api_doc decorator to the api_route one.
    
    Remove the handle_response parameter from the api_doc decorator.
    
    Related to T2657

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/419/ for more details.

Harbormaster completed remote builds in B16355: Diff 15128.Oct 15 2020, 10:04 PM

Rebase

Build is green

Patch application report for D4276 (id=15248)

Rebasing onto 7fbb185005...

Current branch diff-target is up to date.

Changes applied before test

commit 7c5e04cca483dda98c76d7482a7c345a03107676
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Oct 7 16:44:55 2020 +0200

    api: Improve error handling and response management
    
    Use a custom DRF exception handler to generate an error response when an
    exception is raised in a view.
    
    Move api response creation from the api_doc decorator to the api_route one.
    
    Remove the handle_response parameter from the api_doc decorator.
    
    Related to T2657

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/422/ for more details.

Harbormaster completed remote builds in B16480: Diff 15248.Oct 20 2020, 12:47 PM

Closed by commit rDWAPPS7c5e04cca483: api: Improve error handling and response management (authored by anlambert). · Explain WhyOct 20 2020, 1:04 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS7c5e04cca483: api: Improve error handling and response management.