Page MenuHomeSoftware Heritage

Fix mistakes in the deletion flowchart
ClosedPublic

Authored by vlorentz on Tue, Oct 13, 5:29 PM.

Diff Detail

Repository
rDDEP Push deposit
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Tue, Oct 13, 5:29 PM

Build is green

Patch application report for D4249 (id=15011)

Could not rebase; Attempt merge onto a8e6b830bb...

Updating a8e6b830..5a40d27c
Fast-forward
 docs/images/.gitignore               |  1 +
 docs/images/Makefile                 | 10 ++++
 docs/images/deposit-create-chart.uml | 26 +++++++++++
 docs/images/deposit-delete-chart.uml | 38 ++++++++++++++++
 docs/images/deposit-update-chart.uml | 37 +++++++++++++++
 docs/specs/blueprint.rst             | 88 +++++++++++++++++++++++++++++++-----
 6 files changed, 188 insertions(+), 12 deletions(-)
 create mode 100644 docs/images/.gitignore
 create mode 100644 docs/images/Makefile
 create mode 100644 docs/images/deposit-create-chart.uml
 create mode 100644 docs/images/deposit-delete-chart.uml
 create mode 100644 docs/images/deposit-update-chart.uml
Changes applied before test
commit 5a40d27c7cf95dcab4ecd5b8ca862ae90d9635d8
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Oct 13 17:28:57 2020 +0200

    Fix mistakes in the deletion flowchart

commit 5622c4d80cb08b27c0c1f7a32cb69dce156a6d4e
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Oct 13 17:25:26 2020 +0200

    Rewrite blueprint flowcharts using Plantuml instead of .png files.
    
    There are a few mistakes, but they were already in the original files;
    a future commit will fix them.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/228/ for more details.

ardumont accepted this revision.Tue, Oct 13, 6:19 PM
ardumont added a subscriber: ardumont.
ardumont added inline comments.
docs/images/deposit-delete-chart.uml
30

the not should go away, otherwise i don't understand...

This revision is now accepted and ready to land.Tue, Oct 13, 6:19 PM
vlorentz added inline comments.Tue, Oct 13, 8:19 PM
docs/images/deposit-delete-chart.uml
30

oops, yes, indeed

Build is green

Patch application report for D4249 (id=15019)

Could not rebase; Attempt merge onto a8e6b830bb...

Updating a8e6b830..9cf67929
Fast-forward
 docs/images/.gitignore               |  1 +
 docs/images/Makefile                 | 10 ++++
 docs/images/deposit-create-chart.uml | 26 +++++++++++
 docs/images/deposit-delete-chart.uml | 38 ++++++++++++++++
 docs/images/deposit-update-chart.uml | 37 +++++++++++++++
 docs/specs/blueprint.rst             | 88 +++++++++++++++++++++++++++++++-----
 6 files changed, 188 insertions(+), 12 deletions(-)
 create mode 100644 docs/images/.gitignore
 create mode 100644 docs/images/Makefile
 create mode 100644 docs/images/deposit-create-chart.uml
 create mode 100644 docs/images/deposit-delete-chart.uml
 create mode 100644 docs/images/deposit-update-chart.uml
Changes applied before test
commit 9cf6792987285a4e49713f3602dad89e29e8d1dd
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Oct 13 17:28:57 2020 +0200

    Fix mistakes in the deletion flowchart

commit 5622c4d80cb08b27c0c1f7a32cb69dce156a6d4e
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Oct 13 17:25:26 2020 +0200

    Rewrite blueprint flowcharts using Plantuml instead of .png files.
    
    There are a few mistakes, but they were already in the original files;
    a future commit will fix them.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/231/ for more details.

This revision was automatically updated to reflect the committed changes.