Page MenuHomeSoftware Heritage

browse/directory: Fix invalid content links and update display
ClosedPublic

Authored by anlambert on Fri, Oct 9, 6:52 PM.

Details

Summary

Directories do not have permissions bits set in SWH data model so
remove their display as it is confusing.

When browsing a non root directory in an origin context, the path query parameter
value for directory content links was invalid due to dicts not merged in the
right order.

Closes T2677

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Fri, Oct 9, 6:52 PM

Build is green

Patch application report for D4224 (id=14908)

Rebasing onto 47e4659b4c...

Current branch diff-target is up to date.
Changes applied before test
commit f1674dda46c7418e173125a08be5884681c4ef5c
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Oct 9 18:39:28 2020 +0200

    browse/directory: Fix invalid query parameter value for content links
    
    When browsing a non root directory in an origin context, the path query parameter
    value for directory content links was invalid due to dicts not merged in the
    right order.
    
    Closes T2677

commit fcfffdb845e86f15a44da8fea994a9864ca389cf
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Oct 9 18:47:16 2020 +0200

    templates/directory-display: Remove permissions display for directories
    
    Directories do not have permissions bits set in SWH data model so
    remove their display as it is confusing.
    
    Related to T2677

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/406/ for more details.

ardumont accepted this revision.Sat, Oct 10, 8:21 AM
ardumont added a subscriber: ardumont.

lgtm

This revision is now accepted and ready to land.Sat, Oct 10, 8:21 AM