Differential D4154

Fix invalid None value for the list of licenses in tests.
ClosedPublic
Actions

Authored by vlorentz on Oct 6 2020, 2:03 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDCIDX337ac3a79be8: Fix invalid None value for the list of licenses in tests.

Summary

This caused indexers to crash, but they caught the error and returned
uneventful instead.
A future commit will remove this exception silencing, so it will
make tests fail.

Diff Detail

Repository

rDCIDX Metadata indexer

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Oct 6 2020, 2:03 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 6 2020, 2:03 PM

ardumont accepted this revision.Oct 6 2020, 2:05 PM

This revision is now accepted and ready to land.Oct 6 2020, 2:05 PM

Build is green

Patch application report for D4154 (id=14646)

Rebasing onto 3ac0c155da...

Current branch diff-target is up to date.

Changes applied before test

commit 337ac3a79be87269d510b79b34c4fb981fea41e6
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Oct 6 13:56:52 2020 +0200

    Fix invalid None value for the list of licenses in tests.
    
    This caused indexers to crash, but they caught the error and returned
    uneventful instead.
    A future commit will remove this exception silencing, so it will
    make tests fail.

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/64/ for more details.

Harbormaster completed remote builds in B15925: Diff 14646.Oct 6 2020, 2:05 PM

vlorentz added a child revision: D4155: test_generate_content_get_no_result: Pass a multiple of 2 as number of partitions..Oct 6 2020, 2:05 PM

vlorentz removed a child revision: D4155: test_generate_content_get_no_result: Pass a multiple of 2 as number of partitions..

vlorentz added a parent revision: D4155: test_generate_content_get_no_result: Pass a multiple of 2 as number of partitions..

vlorentz added a child revision: D4152: Fix inconsistencies in exception handling between the base indexers..

Closed by commit rDCIDX337ac3a79be8: Fix invalid None value for the list of licenses in tests. (authored by vlorentz). · Explain WhyOct 6 2020, 2:57 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDCIDX337ac3a79be8: Fix invalid None value for the list of licenses in tests..