Differential D4145

java: refactor AllowedEdges to remove its Graph attribute
ClosedPublic
Actions

Authored by seirl on Oct 5 2020, 5:49 PM.

Details

Reviewers

haltode

Commits

rDGRPH8b18ec1cb26b: java: refactor AllowedEdges to remove its Graph attribute

Diff Detail

Repository

rDGRPH Compressed graph representation

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 15898
Build 24470: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 24469: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	3 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.graph.tests.test_api_client::test_count self = <RemoteGraphClient url=http://127.0.0.1:56981/graph/> response = <Response [400]>
	7 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.graph.tests.test_api_client::test_leaves self = <RemoteGraphClient url=http://127.0.0.1:56981/graph/> response = <Response [400]>
	3 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.graph.tests.test_api_client::test_neighbors self = <RemoteGraphClient url=http://127.0.0.1:56981/graph/> response = <Response [400]>
	4 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.graph.tests.test_api_client::test_random_walk self = <RemoteGraphClient url=http://127.0.0.1:56981/graph/> response = <Response [400]>
	3 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.graph.tests.test_api_client::test_visit_edges self = <RemoteGraphClient url=http://127.0.0.1:56981/graph/> response = <Response [400]>
		View Full Test Results (8 Failed · 24 Passed · 2 Skipped)

Event Timeline

seirl created this revision.Oct 5 2020, 5:49 PM

Build has FAILED

Patch application report for D4145 (id=14617)

Rebasing onto b3f110be7a...

Current branch diff-target is up to date.

Changes applied before test

commit 15550e2c880934e1f39ebc97501095c91c0c0acf
Author: Antoine Pietri <antoine.pietri1@gmail.com>
Date:   Mon Oct 5 17:48:56 2020 +0200

    java: refactor AllowedEdges to remove its Graph attribute

Link to build: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/55/
See console output for more information: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/55/console

Harbormaster failed remote builds in B15898: Diff 14617!Oct 5 2020, 5:51 PM

haltode accepted this revision.Oct 5 2020, 6:09 PM

This revision is now accepted and ready to land.Oct 5 2020, 6:09 PM

Just walking by...
Maybe remove also the following import in Graph:
import it.unimi.dsi.big.webgraph.BVGraph;

Fix BVGraph/ImmutableGraph implicit naming

This revision was landed with ongoing or failed builds.Oct 5 2020, 6:22 PM

Closed by commit rDGRPH8b18ec1cb26b: java: refactor AllowedEdges to remove its Graph attribute (authored by seirl). · Explain Why

This revision was automatically updated to reflect the committed changes.

seirl added a commit: rDGRPH8b18ec1cb26b: java: refactor AllowedEdges to remove its Graph attribute.

Build has FAILED

Patch application report for D4145 (id=14620)

Rebasing onto b3f110be7a...

Current branch diff-target is up to date.

Changes applied before test

commit 8b18ec1cb26b32469fd6cb8f1d58e2005b6d54df
Author: Antoine Pietri <antoine.pietri1@gmail.com>
Date:   Mon Oct 5 17:48:56 2020 +0200

    java: refactor AllowedEdges to remove its Graph attribute

Link to build: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/56/
See console output for more information: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/56/console

Harbormaster failed remote builds in B15901: Diff 14620!Oct 5 2020, 6:24 PM