Page MenuHomeSoftware Heritage

swh-fuse: add privileged and device options to the docker container to allow mount to work
ClosedPublic

Authored by vsellier on Oct 5 2020, 4:04 PM.

Diff Detail

Repository
rCJSWH Jenkins jobs
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont added inline comments.
jobs/templates/includes/agent-docker.groovy.j2
5

What's the else condition gonna resolve too?

empty string or something ""?

jobs/templates/includes/agent-docker.groovy.j2
5

It's interpreted as an empty string :

  • when it's not define :
args '--tmpfs /tmp:exec -v /var/run/docker.sock:/var/run/docker.sock -v /usr/bin/docker:/usr/bin/docker -u jenkins:docker --mount type=volume,src=shared-jenkins-cachedir,dst=/home/jenkins/.cache '
  • when it's define :
args '--tmpfs /tmp:exec -v /var/run/docker.sock:/var/run/docker.sock -v /usr/bin/docker:/usr/bin/docker -u jenkins:docker --mount type=volume,src=shared-jenkins-cachedir,dst=/home/jenkins/.cache --privileged --device /dev/fuse'
vsellier retitled this revision from swh-fuse: add a privileged and device option to the docker container to allow mount to work to swh-fuse: add privileged and device options to the docker container to allow mount to work.Oct 6 2020, 9:30 AM
This revision was not accepted when it landed; it landed in state Needs Review.Oct 6 2020, 9:47 AM
This revision was automatically updated to reflect the committed changes.
jobs/templates/includes/agent-docker.groovy.j2
5

thanks.