Differential D4144

swh-fuse: add privileged and device options to the docker container to allow mount to work
ClosedPublic
Actions

Authored by vsellier on Oct 5 2020, 4:04 PM.

Details

Reviewers

None

Group Reviewers

Reviewers

Maniphest Tasks

T2654: modprobe fuse on the CI build machine

Commits

rCJSWH5ade7a89a66b: swh-fuse: add a privileged and device option to the docker container to allow…

Summary

Related to T2654

Test Plan

tox

Diff Detail

Repository

rCJSWH Jenkins jobs

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 15895
Build 24466: arc lint + arc unit

Event Timeline

vsellier created this revision.Oct 5 2020, 4:04 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 5 2020, 4:04 PM

Harbormaster completed remote builds in B15895: Diff 14614.Oct 5 2020, 4:04 PM

ardumont added a subscriber: ardumont.Oct 5 2020, 5:31 PM

ardumont added inline comments.

jobs/templates/includes/agent-docker.groovy.j2
5	What's the else condition gonna resolve too? empty string or something ""?

vsellier added inline comments.Oct 5 2020, 5:53 PM

jobs/templates/includes/agent-docker.groovy.j2

It's interpreted as an empty string :

when it's not define :

args '--tmpfs /tmp:exec -v /var/run/docker.sock:/var/run/docker.sock -v /usr/bin/docker:/usr/bin/docker -u jenkins:docker --mount type=volume,src=shared-jenkins-cachedir,dst=/home/jenkins/.cache '

when it's define :

args '--tmpfs /tmp:exec -v /var/run/docker.sock:/var/run/docker.sock -v /usr/bin/docker:/usr/bin/docker -u jenkins:docker --mount type=volume,src=shared-jenkins-cachedir,dst=/home/jenkins/.cache --privileged --device /dev/fuse'

vsellier retitled this revision from swh-fuse: add a privileged and device option to the docker container to allow mount to work to swh-fuse: add privileged and device options to the docker container to allow mount to work.Oct 6 2020, 9:30 AM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 6 2020, 9:47 AM

Closed by commit rCJSWH5ade7a89a66b: swh-fuse: add a privileged and device option to the docker container to allow… (authored by vsellier). · Explain Why

This revision was automatically updated to reflect the committed changes.

vsellier added a commit: rCJSWH5ade7a89a66b: swh-fuse: add a privileged and device option to the docker container to allow….

ardumont added inline comments.Oct 6 2020, 9:47 AM