Differential D4111

Expose deposit configuration only within the deposit loader tests
ClosedPublic
Actions

Authored by ardumont on Oct 1 2020, 1:51 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDLDBASEd5f9a4574d4c: Expose deposit configuration only within the deposit tests

Test Plan

tox

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 15759
Build 24261: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 24260: arc lint + arc unit

Event Timeline

ardumont created this revision.Oct 1 2020, 1:51 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 1 2020, 1:51 PM

Harbormaster completed remote builds in B15759: Diff 14484.Oct 1 2020, 1:52 PM

Build is green

Patch application report for D4111 (id=14484)

Could not rebase; Attempt merge onto 63e9d3caae...

Updating 63e9d3c..d5f9a45
Fast-forward
 swh/loader/package/deposit/loader.py               |  60 ++++++---
 swh/loader/package/deposit/tests/conftest.py       |  23 ++++
 .../hello_2.10.json                                |  48 ++++---
 .../hello_2.11.json                                |  52 ++++----
 swh/loader/package/deposit/tests/test_deposit.py   | 145 +++++++++++++--------
 swh/loader/pytest_plugin.py                        |   4 -
 6 files changed, 201 insertions(+), 131 deletions(-)
 create mode 100644 swh/loader/package/deposit/tests/conftest.py

Changes applied before test

commit d5f9a4574d4c6947868e0ced2ff4cbb72a1baf2e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 1 13:51:42 2020 +0200

    Expose deposit configuration only within the deposit tests

commit 777ea4468ad3c4e8981151b29f8b70ff7124c4ef
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Sep 30 17:54:49 2020 +0200

    deposit: Adapt loader to send extrinsic raw metadata to the metadata storage
    
    This keeps the metadata written in the revision in the same format as before
    though (json dict).
    
    Related to T2649

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/310/ for more details.

anlambert accepted this revision.Oct 1 2020, 4:01 PM

This revision is now accepted and ready to land.Oct 1 2020, 4:01 PM

Closed by commit rDLDBASEd5f9a4574d4c: Expose deposit configuration only within the deposit tests (authored by ardumont). · Explain WhyOct 1 2020, 4:14 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLDBASEd5f9a4574d4c: Expose deposit configuration only within the deposit tests.