Page MenuHomeSoftware Heritage
Differential D4108

storage.in_memory: use attr classes in the (internal) SubStorage.
ClosedPublic
Actions

Authored by vlorentz on Oct 1 2020, 12:11 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDCIDXcd650f102d68: storage.in_memory: use attr classes in the (internal) SubStorage.
Summary

No change to the interface yet, it's a preliminary change needed
to do it.

Diff Detail

Repository
rDCIDX Metadata indexer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Oct 1 2020, 12:11 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptOct 1 2020, 12:11 PM
swh-public-ci added a comment.Oct 1 2020, 12:12 PM

Build has FAILED

Patch application report for D4108 (id=14473)

Rebasing onto e92b931e47...

Current branch diff-target is up to date.
Changes applied before test
commit 799e3fb0172caeaa58595f9f778ed0eb835a9f22
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Oct 1 12:10:02 2020 +0200

    storage.in_memory: use attr classes in the (internal) SubStorage.
    
    No change to the interface yet, it's a preliminary change needed
    to do it.

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/52/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/52/console

Harbormaster failed remote builds in B15749: Diff 14473!Oct 1 2020, 12:13 PM
vlorentz updated this revision to Diff 14474.Oct 1 2020, 12:13 PM

remove debug prints

swh-public-ci added a comment.Oct 1 2020, 12:15 PM

Build has FAILED

Patch application report for D4108 (id=14474)

Rebasing onto e92b931e47...

Current branch diff-target is up to date.
Changes applied before test
commit 02e226b0ab9d75746950ceb122b5b2dd76a7d644
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Oct 1 12:10:02 2020 +0200

    storage.in_memory: use attr classes in the (internal) SubStorage.
    
    No change to the interface yet, it's a preliminary change needed
    to do it.

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/53/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/53/console

Harbormaster failed remote builds in B15750: Diff 14474!Oct 1 2020, 12:15 PM
ardumont added a subscriber: ardumont.Oct 1 2020, 12:30 PM

lgtm

tests unhappy though and i have one question inline.

swh/indexer/storage/in_memory.py
64

What does this means?

swh/indexer/storage/model.py
6

by* the

35

not-None?

why not plain not None ? (same question for the raise below).

vlorentz marked 2 inline comments as done.Oct 1 2020, 12:36 PM
vlorentz added inline comments.
swh/indexer/storage/in_memory.py
64

https://docs.python.org/3/library/typing.html#user-defined-generic-types

and bound=BaseRow means its values can only be subclasses of BaseRow.

swh/indexer/storage/model.py
35

whatever

vlorentz marked an inline comment as done.Oct 1 2020, 12:37 PM
In D4108#101713, @ardumont wrote:

tests unhappy though

Oh yeah, forgot to tag D4087

vlorentz updated this revision to Diff 14476.Oct 1 2020, 12:38 PM

apply comments

swh-public-ci added a comment.Oct 1 2020, 12:40 PM

Build has FAILED

Patch application report for D4108 (id=14476)

Rebasing onto e92b931e47...

Current branch diff-target is up to date.
Changes applied before test
commit cd650f102d686c5d7e95fe9dc4f1e4b0e87f4066
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Oct 1 12:10:02 2020 +0200

    storage.in_memory: use attr classes in the (internal) SubStorage.
    
    No change to the interface yet, it's a preliminary change needed
    to do it.

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/54/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/54/console

Harbormaster failed remote builds in B15752: Diff 14476!Oct 1 2020, 12:40 PM
ardumont accepted this revision.Oct 1 2020, 12:41 PM

should tag the core first though then ;)

swh/indexer/storage/in_memory.py
64

thanks

This revision is now accepted and ready to land.Oct 1 2020, 12:41 PM
swh-public-ci added a comment.Oct 1 2020, 2:04 PM

Build is green

Patch application report for D4108 (id=14476)

Rebasing onto e92b931e47...

Current branch diff-target is up to date.
Changes applied before test
commit cd650f102d686c5d7e95fe9dc4f1e4b0e87f4066
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Oct 1 12:10:02 2020 +0200

    storage.in_memory: use attr classes in the (internal) SubStorage.
    
    No change to the interface yet, it's a preliminary change needed
    to do it.

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/55/ for more details.

Harbormaster completed remote builds in B15752: Diff 14476.Oct 1 2020, 2:04 PM
Closed by commit rDCIDXcd650f102d68: storage.in_memory: use attr classes in the (internal) SubStorage. (authored by vlorentz). · Explain WhyOct 1 2020, 6:14 PM
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDCIDXcd650f102d68: storage.in_memory: use attr classes in the (internal) SubStorage..

Revision Contents
Changeset List

PathSize
swh/
indexer/
storage/
185 lines
119 lines

Diff 14512

View Options

swh/indexer/storage/in_memory.py

Loading...
View Options

swh/indexer/storage/model.py

Loading...
About · Developer information · Legal