Page MenuHomeSoftware Heritage
Differential D4079

Remove swh.journal.serializers.object_key, use BaseModel.unique_key instead.
ClosedPublic
Actions

Authored by vlorentz on Sep 29 2020, 2:16 PM.

Details

Reviewers
olasd
Group Reviewers
Reviewers
Commits
rDJNLabc42e2bf7a9: Remove swh.journal.serializers.object_key, use BaseModel.unique_key instead.
Summary

Code was moved to swh-model in D4078.

Depends on D4078

Diff Detail

Repository
rDJNL Journal infrastructure
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Sep 29 2020, 2:16 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptSep 29 2020, 2:16 PM
vlorentz planned changes to this revision.Sep 29 2020, 2:16 PM
vlorentz retitled this revision from Remove swh.journal.serializers.object_key, use BaseModel.unique_key instead. to [WIP] Remove swh.journal.serializers.object_key, use BaseModel.unique_key instead..Sep 29 2020, 2:16 PM
swh-public-ci added a comment.Sep 29 2020, 2:17 PM

Build has FAILED

Patch application report for D4079 (id=14394)

Rebasing onto 7815cad28a...

Current branch diff-target is up to date.
Changes applied before test
commit 1a64c96f97d8b6a56a873a269af88859083359ea
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Sep 29 14:15:35 2020 +0200

    Remove swh.journal.serializers.object_key, use BaseModel.unique_key instead.

Link to build: https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/111/
See console output for more information: https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/111/console

Harbormaster failed remote builds in B15688: Diff 14394!Sep 29 2020, 2:17 PM
vlorentz added a child revision: D4080: Make value_sanitizer an argument of JournalWriter..Sep 29 2020, 3:08 PM
vlorentz edited the summary of this revision. (Show Details)
vlorentz added a parent revision: D4078: Add a 'unique_key' method on model objects.
vlorentz requested review of this revision.Oct 8 2020, 11:18 AM
vlorentz retitled this revision from [WIP] Remove swh.journal.serializers.object_key, use BaseModel.unique_key instead. to Remove swh.journal.serializers.object_key, use BaseModel.unique_key instead..
olasd accepted this revision.Oct 12 2020, 12:00 PM
olasd added a subscriber: olasd.

Please update requirements-swh.txt with the new version of swh.model when landing this

This revision is now accepted and ready to land.Oct 12 2020, 12:00 PM
vlorentz updated this revision to Diff 14926.Oct 12 2020, 12:19 PM

update requirements-swh.txt

swh-public-ci added a comment.Oct 12 2020, 12:20 PM

Build is green

Patch application report for D4079 (id=14926)

Rebasing onto d3c09acb40...

First, rewinding head to replay your work on top of it...
Applying: Remove swh.journal.serializers.object_key, use BaseModel.unique_key instead.
Changes applied before test
commit 411e3e02e588b9ed6f2c40b7546f6ce4bd4f03c6
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Sep 29 14:15:35 2020 +0200

    Remove swh.journal.serializers.object_key, use BaseModel.unique_key instead.

See https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/115/ for more details.

Harbormaster completed remote builds in B16158: Diff 14926.Oct 12 2020, 12:20 PM
vlorentz updated this revision to Diff 14930.Oct 12 2020, 12:22 PM

rebase

This revision was landed with ongoing or failed builds.Oct 12 2020, 12:22 PM
Closed by commit rDJNLabc42e2bf7a9: Remove swh.journal.serializers.object_key, use BaseModel.unique_key instead. (authored by vlorentz). · Explain Why
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDJNLabc42e2bf7a9: Remove swh.journal.serializers.object_key, use BaseModel.unique_key instead..
swh-public-ci added a comment.Oct 12 2020, 12:24 PM

Build is green

Patch application report for D4079 (id=14930)

Rebasing onto abc42e2bf7...

First, rewinding head to replay your work on top of it...
Fast-forwarded diff-target to base-revision-118-D4079.
Changes applied before test



See https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/118/ for more details.
Harbormaster completed remote builds in B16162: Diff 14930.Oct 12 2020, 12:24 PM
Revision Contents
Changeset List
PathSize
2 lines
swh/
journal/
4 lines
80 lines
tests/
11 lines
writer/
3 lines
Diff 14931
View Options
requirements-swh.txt
Loading...
View Options
swh/journal/pytest_plugin.py
Loading...
View Options
swh/journal/serializers.py
Loading...
View Options
swh/journal/tests/test_serializers.py
Loading...
View Options
swh/journal/writer/kafka.py
Loading...
About · Developer information · Legal