Page MenuHomeSoftware Heritage
Differential D405

cookers: readable message for SQL timeouts
ClosedPublic
Actions

Authored by seirl on Sep 5 2018, 2:29 PM.

Details

Reviewers
zack
Group Reviewers
Reviewers

Diff Detail

Repository
rDVAU Software Heritage Vault
Branch
timeouts
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5399
Build 7311: tox-on-jenkinsJenkins
Build 7310: arc lint + arc unit

Event Timeline

seirl created this revision.Sep 5 2018, 2:29 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptSep 5 2018, 2:29 PM
Harbormaster completed remote builds in B1376: Diff 1264.Sep 5 2018, 2:29 PM
zack accepted this revision.Sep 5 2018, 2:35 PM
zack added a subscriber: zack.

looks good to me, just two minor nits for your consideration:

  • import the exception name directly, as we don't use anything else from that module
  • I'd word it as "Timeout reached while assembling requested bundle"
This revision is now accepted and ready to land.Sep 5 2018, 2:35 PM
seirl closed this revision.Oct 1 2018, 7:43 PM

Already merged.

seirl reopened this revision.Oct 1 2018, 7:54 PM

oops

This revision is now accepted and ready to land.Oct 1 2018, 7:54 PM
olasd added a subscriber: olasd.Apr 10 2019, 6:12 PM

@seirl can you land this after applying @zack's comments?

seirl updated this revision to Diff 4548.Apr 12 2019, 2:39 PM

update with zack's comments

seirl closed this revision.Apr 12 2019, 2:40 PM
Harbormaster failed remote builds in B5399: Diff 4548!Apr 12 2019, 2:40 PM
swh-public-ci added a comment.Apr 12 2019, 2:40 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DVAU/job/tox/62/
See console output for more information: https://jenkins.softwareheritage.org/job/DVAU/job/tox/62/console

Revision Contents
Changeset List

PathSize
swh/
vault/
cookers/
7 lines

Diff 4548

View Options

swh/vault/cookers/base.py

Loading...
About · Developer information · Legal