Page MenuHomeSoftware Heritage

Add specific celery task arguments to metadata sent to systemd-journald
ClosedPublic

Authored by olasd on Sep 25 2020, 9:03 AM.

Details

Summary

We used to log all task arguments, which was a bit too much for the logging
pipeline to handle. Now that a lot of tasks arguments have been "canonicalized",
we can go back to logging some specific arguments directly.

Use the opportunity to drop an unused argument and improve the documentation of
these logging-related functions.

Related to D4012

Test Plan

I'm not quite sure how to add tests to this stuff...

Diff Detail

Repository
rDCORE Foundations and core functionalities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D4043 (id=14258)

Rebasing onto 7c117c3dd0...

Current branch diff-target is up to date.
Changes applied before test
commit d46d4c7ac578141fd67b5af78108d53ab2ccdf62
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Fri Sep 25 08:59:13 2020 +0200

    Add specific celery task arguments to metadata sent to systemd-journald
    
    We used to log all task arguments, which was a bit too much for the logging
    pipeline to handle. Now that a lot of tasks arguments have been "canonicalized",
    we can go back to logging some specific arguments directly.
    
    Use the opportunity to drop an unused argument and improve the documentation of
    these logging-related functions.

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/85/ for more details.

This revision is now accepted and ready to land.Sep 25 2020, 9:45 AM