loader*: Migrate to swh.core.config.load_from_envvar
AbandonedPublic
Actions

Authored by ardumont on Sep 22 2020, 1:51 PM.

Details

Reviewers

None

Group Reviewers

Maniphest Tasks

T1532: Cleanup deprecated configuration code in swh modules
T1410: Kill implicit configuration: new configuration scheme

Summary

Related to T1532
Related to T1410

Test Plan

tox (failing until swh.core release >= 0.3.0)

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 15400
Build 23722: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 23721: arc lint + arc unit

Event Timeline

ardumont created this revision.Sep 22 2020, 1:51 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 22 2020, 1:51 PM

Build has FAILED

Patch application report for D4007 (id=14133)

Rebasing onto 452fa224f9...

Current branch diff-target is up to date.

Changes applied before test

commit 61e6a4a1629d6b7b7ba5ffd84f9c719dbd0fab34
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Sep 22 13:52:09 2020 +0200

    loader*: Migrate to swh.core.config.load_from_envvar
    
    Related to T1352
    Related to T1410

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/299/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/299/console

Harbormaster failed remote builds in B15398: Diff 14133!Sep 22 2020, 1:52 PM

ardumont edited the test plan for this revision. (Show Details)Sep 22 2020, 2:02 PM

Fix misindentation

Build has FAILED

Patch application report for D4007 (id=14135)

Rebasing onto 452fa224f9...

Current branch diff-target is up to date.

Changes applied before test

commit 0de33371f90772dae502dfc56f438f9daefd32df
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Sep 22 13:52:09 2020 +0200

    loader*: Migrate to swh.core.config.load_from_envvar
    
    This simplifies the loading mechanism, delegating the loading to that function.
    
    Related to T1352
    Related to T1410

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/300/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/300/console

Harbormaster failed remote builds in B15400: Diff 14135!Sep 22 2020, 2:05 PM

ardumont planned changes to this revision.Sep 22 2020, 2:14 PM

ardumont abandoned this revision.Sep 22 2020, 2:55 PM

ardumont edited the summary of this revision. (Show Details)

ardumont added a task: T1532: Cleanup deprecated configuration code in swh modules.

ardumont removed a task: T1352: ingest Guix (SD) packages.