Differential D4001

Rename 10-swh-init.sql as 10-superuser-init.sql
ClosedPublic
Actions

Authored by douardda on Sep 22 2020, 10:21 AM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDSTO30cdb78f17eb: Drop the -swh- part of sql files
rDSTO915575d5b50a: Rename 10-swh-init.sql as 10-superuser-init.sql

Summary

so the db initialization from swh.core (>= 0.3) executes this during the
database creation step (i.e. while having a superuser level connection
to the database).

Also drop the -swh- part of sql files,
it does not bring any meaningful info and makes it somewhat inconsistent with
the new -superuser- "tag".

Diff Detail

Repository

rDSTO Storage manager

Branch

master

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 15379
Build 23685: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 23684: arc lint + arc unit

Event Timeline

douardda created this revision.Sep 22 2020, 10:21 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 22 2020, 10:21 AM

thanks.

This revision is now accepted and ready to land.Sep 22 2020, 10:25 AM

Build is green

Patch application report for D4001 (id=14113)

Rebasing onto 67ee86b8e0...

Current branch diff-target is up to date.

Changes applied before test

commit 30cdb78f17ebc25e8d0690a3adac08c726bd5627
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Sep 22 10:18:07 2020 +0200

    Drop the -swh- part of sql files
    
    it does not bring any meaningful info and makes it somewhat inconsistent with
    the new -superuser- "tag".

commit 915575d5b50a3b34b5d7d3f3cdc2d01edf18c984
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Sep 22 10:14:15 2020 +0200

    Rename 10-swh-init.sql as 10-superuser-init.sql
    
    so the db initialization from swh.core (>= 0.3) executes this during the
    database creation step (i.e. while having a superuser level connection
    to the database).

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/954/ for more details.

Harbormaster completed remote builds in B15379: Diff 14113.Sep 22 2020, 10:25 AM

Closed by commit rDSTO915575d5b50a: Rename 10-swh-init.sql as 10-superuser-init.sql (authored by douardda). · Explain WhySep 22 2020, 10:32 AM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDSTO915575d5b50a: Rename 10-swh-init.sql as 10-superuser-init.sql.

douardda added a commit: rDSTO30cdb78f17eb: Drop the -swh- part of sql files.