Paths

Table of Contentst

Differential D39

T288 - Open /api/1/revision/origin/<origin_id>/[branch/<branch_name>][ts/<ts>]/log/
ClosedPublic
Actions

Authored by jbertran on Jun 6 2016, 2:39 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Maniphest Tasks

T288: Open /api/1/revision/origin/<origin_id>/[branch/<branch_name>][ts/<ts>]/log/

Commits

R65:abae1d1c04b3: api: add origin-based revision log lookup routes, update tests to match
R65:73a1f70294c9: service: change rev_log_by to match behaviour of other functions, update tests…
R65:597969ebb7ae: backend: add origin-based revision log lookup, update backend tests to match
R65:4089c0337042: service: add origin-based revision log lookup, update tests to match
R65:011598927c88: api: fix error msg computation error in rev_log_by
rDWAPPSabae1d1c04b3: api: add origin-based revision log lookup routes, update tests to match
rDWAPPS73a1f70294c9: service: change rev_log_by to match behaviour of other functions, update…
rDWAPPS011598927c88: api: fix error msg computation error in rev_log_by
rDWAPPS4089c0337042: service: add origin-based revision log lookup, update tests to match
rDWAPPS597969ebb7ae: backend: add origin-based revision log lookup, update backend tests to match

Summary

Add origin-based revision log lookup to the api endpoints.

Test Plan

included

Diff Detail

Repository

rDWAPPS Web applications

Branch

T288

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 157
Build 232: Software Heritage Python tests
Build 231: arc lint + arc unit

Event Timeline

jbertran updated this revision to Diff 127.Jun 6 2016, 2:39 PM

jbertran added a task: T288: Open /api/1/revision/origin/<origin_id>/[branch/<branch_name>][ts/<ts>]/log/.

jbertran retitled this revision from to T288 - Open /api/1/revision/origin/<origin_id>/[branch/<branch_name>][ts/<ts>]/log/.

jbertran updated this object.

jbertran edited the test plan for this revision. (Show Details)

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 6 2016, 2:39 PM

ardumont added a subscriber: ardumont.Jun 6 2016, 6:02 PM

ardumont added inline comments.

swh/web/ui/backend.py
203	What is the code between """? If it's not used, just remove it.
swh/web/ui/service.py
320	Compute the error_msg only if there is an actual error ^^

ardumont requested changes to this revision.Jun 6 2016, 6:02 PM

ardumont added a reviewer: ardumont.

This revision now requires changes to proceed.Jun 6 2016, 6:02 PM

jbertran added inline comments.Jun 6 2016, 9:01 PM

swh/web/ui/backend.py
203	This is pending T432, I just need the function exposed in storage, figured I'd comment it out in the mean time. I suppose I can just remove it and remember to add it back once T432 is done.
swh/web/ui/service.py
320	Oops.

ardumont added inline comments.Jun 6 2016, 11:10 PM

swh/web/ui/backend.py
203	This is pending T432, I just need the function exposed in storage, figured I'd comment it out in the mean time. I suppose I can just remove it and remember to add it back once T432 is done. Use `git stash` ^^

service: change rev_log_by to match behaviour of other functions,
api: fix error msg computation error in rev_log_by

ardumont accepted this revision.Jun 7 2016, 12:14 PM

ardumont edited edge metadata.

This revision is now accepted and ready to land.Jun 7 2016, 12:14 PM

Closed by commit rDWAPPS597969ebb7ae: backend: add origin-based revision log lookup, update backend tests to match (authored by jbertran). · Explain WhyJun 7 2016, 12:15 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

web/

ui/

30 lines

29 lines

tests/

test_backend.py

56 lines

test_service.py

85 lines

views/

79 lines

views/

32 lines

Diff 127

swh/web/ui/backend.py

Loading...

swh/web/ui/service.py

Loading...

swh/web/ui/tests/test_backend.py

Loading...

swh/web/ui/tests/test_service.py

Loading...

swh/web/ui/tests/views/test_api.py

Loading...

swh/web/ui/views/api.py

Loading...